Prevent macOS Server worker stack overflow - #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a macOS-only WebCodex Server crash observed during real OpenAI Secure MCP Tunnel dogfood.
A normal MCP request could reach the local Server and abort a Tokio worker with
stack overflow. The same request succeeded whenRUST_MIN_STACK=8388608was supplied diagnostically.This change makes the
webcodex-serverbinary build its Tokio multi-thread runtime explicitly and uses an 8 MiB worker stack on macOS only. Linux and Windows retain Tokio's default worker stack behavior.Evidence
webcodex share --tunnel openaicallsRUST_MIN_STACK=8388608removed the crashcargo fmt -- --checkpassedRUST_MIN_STACKexplicitly unset, liveshare --tunnel openaireached/healthz=200and/readyz=200initializeandtools/listboth returned HTTP 200 and the Server remained aliveThe branch was rebased cleanly onto current
main; the intervening #162 change is Windows Runner-only and does not overlap this fix.