Skip to content

test(orchestrator): stabilize concurrent worker cap test #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
setkyar wants to merge 1 commit into from
Closed

test(orchestrator): stabilize concurrent worker cap test #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions services/orchestrator/internal/manager/worker_cap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ package manager
import (
"context"
"fmt"
"os"
"os/exec"
"path/filepath"
"sync"
"testing"

Expand Down Expand Up @@ -79,11 +81,16 @@ func TestSpawnWorker_ConcurrentAdmissionRespectsLimit(t *testing.T) {
t.Skip("timing test")
}

m := New(Config{WhatsAppBinaryPath: "/bin/sh", MaxWorkers: 3})
workerPath := filepath.Join(t.TempDir(), "long-running-worker")
require.NoError(t, os.WriteFile(workerPath, []byte("#!/bin/sh\nsleep 60\n"), 0o700))

m := New(Config{WhatsAppBinaryPath: workerPath, MaxWorkers: 3})
m.ctx, m.cancel = context.WithCancel(context.Background())
defer m.cancel()

// Use real short-lived processes so cmd.Start() succeeds.
// Keep admitted processes alive until every concurrent request reaches the
// admission gate. A short-lived command can exit and free its slot before
// the remaining requests arrive, which tests throughput instead of the cap.
var wg sync.WaitGroup
var mu sync.Mutex
var admitted, rejected int
Expand Down
Loading