test(orchestrator): stabilize concurrent worker cap test - #159
Closed
setkyar wants to merge 1 commit into
Closed
Conversation
setkyar
force-pushed
the
fix/worker-cap-concurrency-test
branch
from
August 27, 2026 19:49
573ef23 to
7fb737c
Compare
Contributor
Author
|
Superseded by consolidated dependency update #158, which includes this change and runs the complete CI suite once against the final combined dependency set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concurrent worker-cap test used
/bin/shwith no arguments. That process exits immediately, allowing its reserved worker slot to be removed before all six requests reach the admission gate. Depending on scheduler timing (especially under-race), the test incorrectly counted more than three successful requests over time even though no more than three workers existed concurrently.Use a temporary long-running worker script so all admitted slots remain occupied until assertions and cleanup.
Validation:
-race, 20 repetitions./scripts/run-go-race.shgit diff --check