Skip to content

test(orchestrator): stabilize concurrent worker cap test - #159

Closed
setkyar wants to merge 1 commit into
mainfrom
fix/worker-cap-concurrency-test
Closed

test(orchestrator): stabilize concurrent worker cap test#159
setkyar wants to merge 1 commit into
mainfrom
fix/worker-cap-concurrency-test

Conversation

@setkyar

@setkyar setkyar commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

The concurrent worker-cap test used /bin/sh with no arguments. That process exits immediately, allowing its reserved worker slot to be removed before all six requests reach the admission gate. Depending on scheduler timing (especially under -race), the test incorrectly counted more than three successful requests over time even though no more than three workers existed concurrently.

Use a temporary long-running worker script so all admitted slots remain occupied until assertions and cleanup.

Validation:

  • target test under -race, 20 repetitions
  • full ./scripts/run-go-race.sh
  • git diff --check

@setkyar
setkyar force-pushed the fix/worker-cap-concurrency-test branch from 573ef23 to 7fb737c Compare August 27, 2026 19:49
@setkyar

setkyar commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by consolidated dependency update #158, which includes this change and runs the complete CI suite once against the final combined dependency set.

@setkyar setkyar closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant