Skip to content

Support misaligned load/store in executor memory#625

Merged
MauroToscano merged 15 commits into
mainfrom
fix_misalign_memory_access
May 29, 2026
Merged

Support misaligned load/store in executor memory#625
MauroToscano merged 15 commits into
mainfrom
fix_misalign_memory_access

Conversation

@gabrielbosio
Copy link
Copy Markdown
Collaborator

No description provided.

@gabrielbosio gabrielbosio force-pushed the fix_misalign_memory_access branch from 516cfcd to 827797c Compare May 26, 2026 18:51
@gabrielbosio gabrielbosio force-pushed the fix_misalign_memory_access branch from 827797c to a988fbe Compare May 26, 2026 18:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

Benchmark Results for unmodified programs 🚀

Command Mean [ms] Min [ms] Max [ms] Relative
base binary_search 59.7 ± 0.8 58.5 60.7 1.00
head binary_search 59.8 ± 1.6 58.0 62.2 1.00 ± 0.03
Command Mean [ms] Min [ms] Max [ms] Relative
base bitwise_ops 58.5 ± 1.0 57.6 60.8 1.00 ± 0.03
head bitwise_ops 58.4 ± 1.6 57.1 61.4 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base fibonacci_26 63.2 ± 1.0 62.2 64.9 1.00
head fibonacci_26 64.0 ± 1.2 62.9 66.3 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base hashmap 135.8 ± 2.7 130.2 138.9 1.00
head hashmap 136.1 ± 2.4 132.0 139.7 1.00 ± 0.03
Command Mean [ms] Min [ms] Max [ms] Relative
base keccak 128.9 ± 3.3 125.4 136.1 1.00
head keccak 132.4 ± 2.4 127.2 135.0 1.03 ± 0.03
Command Mean [ms] Min [ms] Max [ms] Relative
base matrix_multiply 64.1 ± 0.5 62.9 64.7 1.00
head matrix_multiply 66.0 ± 1.7 63.9 70.0 1.03 ± 0.03
Command Mean [ms] Min [ms] Max [ms] Relative
base modular_exp 60.3 ± 1.4 58.8 62.2 1.00
head modular_exp 60.4 ± 1.4 58.6 62.4 1.00 ± 0.03
Command Mean [ms] Min [ms] Max [ms] Relative
base quicksort 63.7 ± 1.1 62.2 64.9 1.00
head quicksort 67.0 ± 9.3 63.1 93.3 1.05 ± 0.15
Command Mean [ms] Min [ms] Max [ms] Relative
base sieve 65.8 ± 0.4 65.1 66.3 1.00 ± 0.01
head sieve 65.7 ± 0.8 65.1 67.9 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base sum_array 75.5 ± 0.8 74.2 76.6 1.01 ± 0.02
head sum_array 74.7 ± 1.1 73.7 77.3 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base syscall_commit 92.1 ± 0.7 91.2 93.5 1.00 ± 0.02
head syscall_commit 92.0 ± 1.4 91.0 95.9 1.00

@yetanotherco yetanotherco deleted a comment from github-actions Bot May 26, 2026
@gabrielbosio
Copy link
Copy Markdown
Collaborator Author

/claude /codex

Comment thread executor/programs/asm/misalign_lw.s
Comment thread executor/src/vm/memory.rs
@yetanotherco yetanotherco deleted a comment from claude Bot May 26, 2026
@yetanotherco yetanotherco deleted a comment from github-actions Bot May 26, 2026
@gabrielbosio
Copy link
Copy Markdown
Collaborator Author

/claude /codex

@gabrielbosio gabrielbosio marked this pull request as ready for review May 26, 2026 20:24
Comment thread executor/src/vm/memory.rs Outdated
Comment thread executor/programs/asm/misalign_sw.s
Comment thread executor/src/vm/memory.rs Outdated
Comment thread executor/programs/asm/misalign_sd.s
@yetanotherco yetanotherco deleted a comment from github-actions Bot May 26, 2026
@yetanotherco yetanotherco deleted a comment from claude Bot May 26, 2026
@yetanotherco yetanotherco deleted a comment from github-actions Bot May 26, 2026
@yetanotherco yetanotherco deleted a comment from claude Bot May 26, 2026
@gabrielbosio
Copy link
Copy Markdown
Collaborator Author

/claude /codex

Comment thread executor/src/vm/memory.rs Outdated
@yetanotherco yetanotherco deleted a comment from github-actions Bot May 26, 2026
@gabrielbosio
Copy link
Copy Markdown
Collaborator Author

/claude /codex

@github-actions
Copy link
Copy Markdown

Codex Code Review

No issues found in the PR diff.

I could not run the targeted tests because rustup tried to write to /home/runner/.rustup, which is read-only in this sandbox:

error: could not create temp file /home/runner/.rustup/tmp/...: Read-only file system

Static review of the changed memory/execution paths did not surface security, correctness, or significant performance concerns.

@gabrielbosio
Copy link
Copy Markdown
Collaborator Author

/bench

@github-actions
Copy link
Copy Markdown

Benchmark — fib_iterative_8M (median of 3)

Table parallelism: auto (cores / 3)

Metric main PR Δ
Peak heap 51873 MB 51815 MB -58 MB (-0.1%) ⚪
Prove time 25.072s 24.988s -0.084s (-0.3%) ⚪

✅ No significant change.

✅ Low variance (time: 0.3%, heap: 0.5%)

Commit: b9ac3b8 · Baseline: cached · Runner: self-hosted bench

@MauroToscano MauroToscano added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit 09ef37d May 29, 2026
18 checks passed
@MauroToscano MauroToscano deleted the fix_misalign_memory_access branch May 29, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants