Repository navigation
feat(capture): recover rejected scans through shared Core review - #61
Conversation
|
Review: FINDINGS head=7a582b8e560782d877b8e6b13787a96f9aa74a54 patch-id=e3dadc1219f6b4a2e54e661dcd23f8649e799618 pr=61 |
|
Review: FINDINGS head=5da6a04090ad10bb55a9a012cd17c4fa2755a1a6 patch-id=36734facedfb926c2b41051b544eb187e84e1d57 pr=61 |
Cross-project architecture gate — 2026-11-17 (documentation only)This child Draft implements bounded capture-recovery UI using the existing private PuzlWerk ReScript package; technical review CLEAR and green CI on this head do not establish cross-project prioritization or CubeAssembler M2 approval. Per Cubistry #21, the existing-solver 2×2 Counter M1 (ReScript core, TypeScript viewer and loadable/oriented sticker assets) must be accepted first; M2 and CubeLab M3 need separate owner gates. The implementation exception recorded in PuzlWerk #85 is specifically scoped to that Core Draft, not a blanket consumer rollout authorization. Before Ready/merge, explicitly document any owner-approved pre-M1 scope for this application feature, alongside parent #60, live/physical acceptance, bounded-versus-full NxN evidence and license/distribution clearance. Existing source/photograph identity and working functionality should remain intact. This is not a request to implement or merge anything. |
|
Review: CLEAR head=5da6a04090ad10bb55a9a012cd17c4fa2755a1a6 patch-id=c9d382d0ef112f55ea237acfc0d8bb3e380c46b5 pr=61 |
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
5da6a04 to
bfbf79c
Compare
|
Carried-over: from=5da6a04090ad10bb55a9a012cd17c4fa2755a1a6 to=bfbf79cc1d3372c874bd7c3db028a416e3208f94 patch-id=c9d382d0ef112f55ea237acfc0d8bb3e380c46b5 pr=61 |
A rejected guided proposal or physical-guide conflict now offers Find a matching cube. The existing photos and reviewed colors enter an explicit bounded PuzlWerk ReScript search; no camera retake or free assignment editor is required.
Validation: 11/11 browser and 2/2 actual-checker adapter cases on 7a582b8; final 6/6 browser delta on 5da6a04. Ten compiled counter-mutants detected across both stages. Final typecheck, lint, format, build and typos exit 0. Original 19:08 and 21:28 captures are exercised without photo/color/protocol edits; selected source hashes and export/reimport are checked.
Base: #60 is merged; this PR is rebased onto main (head bfbf79c, same patch-id as the reviewed 5da6a04). Private Core 0.3.0 is pinned to PuzlWerk source f1fa30ac2c12b507be9c6f3041fe7ef316378c37 (an earlier wstein/puzlwerk#85 head; the archive differs from the current one only in provenance.json); no registry publication or sibling checkout is needed.
R1 follow-up binds actions to their exact opaque review/Core revision and active capture; neutral source review now carries Photo-N names through title, dialog and image alt.
Review CLEAR at the pre-rebase head 5da6a04 and carried over to this head with the same patch-id (Carried-over comment on this PR). CI at this head: CI run 44136132716 success; CI at the pre-rebase head: 1436 unit cases (6 expected failures, 2 skips) and 203/203 browser cases without retries.
Owner gates at merge: license/distribution (EUPL-1.2 Core in the MIT app), physical-owner acceptance, M1 sequence per Cubistry #21. Parent #60 and wstein/puzlwerk#85 are merged. Complete NxN reachability remains unverified.
Merge publishes: pages.yml deploys on every push to main, so merging ships the vendored EUPL-1.2 Core in the app bundle via GitHub Pages.
Blocker: None.
Manual steps are in docs/orientation-recovery.md. Local before/after desktop and touch captures accompany the author report.
🤖 Generated with Claude Code