Repository navigation
fix(capture): preserve photo identity through cube review - #60
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
Review: FINDINGS head=ec92f3390fe00a01e2627c92057eea1b4d2f02c0 patch-id=5c155eac576751845414584010a076c49192e4dc pr=60 |
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
Review: FINDINGS head=41314a27cfd972ede4a7961409f65d2a03c26b75 patch-id=09d300fbd88ed2b9cf5257aa8b1c991ec065530f pr=60 |
Cross-project architecture gate — 2026-11-17 (documentation only)This photo-provenance fix and its pinned private PuzlWerk ReScript capture package are not evidence of an approved CubeAssembler M2 migration. The binding order remains Cubistry #21: independently accept the existing-solver 2×2 Counter M1 (ReScript core, separate TypeScript viewer, loadable/oriented sticker assets), then separately authorize CubeAssembler M2, then CubeLab M3. The bounded Core capture implementation PuzlWerk #85 has its own explicit Draft-scope exception, but its stated terms do not authorize a consumer migration, publication or distribution. Before moving this Draft toward Ready/merge, document whether this narrow CubeAssembler capture fix is independently owner-authorized ahead of M1, and clear the already-listed physical acceptance, parent/Core, provenance and license/distribution gates. Preserve the working capture/renderer and this technical review evidence. No additional feature, dependency or merge is authorized by this note. |
|
Review: CLEAR head=41314a27cfd972ede4a7961409f65d2a03c26b75 patch-id=09d300fbd88ed2b9cf5257aa8b1c991ec065530f pr=60 |
Fixes captured-photo aliases in approval, the canonical net and per-face color review. Photo links now use explicit source IDs through the private PuzlWerk ReScript package; ambiguous legacy links remain unknown.
Validation: 24 targeted units and 6 provenance browser cases; 5 lifecycle regressions plus an unchanged camera completion; independent F1 delta review passed. The two legacy roundtrip contracts now pass (2/2); typecheck, lint, format, build and typos exit 0 at 41314a2.
Exact-head validation at 41314a2: independent review CLEAR; CI passed 189/189 browser cases without retries and 1434 unit cases (6 expected failures, 2 skips). The legacy tests preserve exact state/identity and establish explicit provenance before testing absolute rotations.
Owner gates at merge: parent Core wstein/puzlwerk#85, license/distribution (EUPL-1.2 Core in the MIT app), physical-owner acceptance, M1 sequence per Cubistry #21.
Merge publishes: pages.yml deploys on every push to main, so merging ships the vendored EUPL-1.2 Core in the app bundle via GitHub Pages.
Blocker: None.
Private Core 0.1.0 is pinned to PuzlWerk source f7a0082fbb6683400cd8d34feed4cae36a8a5ba4 (an earlier #85 head; #61 replaces the pin). Recovery search is a separate follow-up. Physical-owner acceptance, complete NxN reachability and distribution/license approval remain open.
🤖 Generated with Claude Code