Skip to content

fix(capture): preserve photo identity through cube review - #60

Merged
wstein merged 6 commits into
mainfrom
fix/capture-photo-provenance
Nov 17, 2026
Merged

wstein merged 6 commits into
mainfrom
fix/capture-photo-provenance

Conversation

@wstein

@wstein wstein commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Fixes captured-photo aliases in approval, the canonical net and per-face color review. Photo links now use explicit source IDs through the private PuzlWerk ReScript package; ambiguous legacy links remain unknown.

  • Keeps original photos, recognition grids and guide observations separate from reviewed colors and logical approval.
  • Preserves six source identities before Use and across export/reimport; rejects stale retake bindings.
  • Cancels obsolete digest/import operations on close, reset, size change and newer input, including late loading/error updates.
  • Retains logical Yes and explicit invalid inspection without inventing source mappings.

Validation: 24 targeted units and 6 provenance browser cases; 5 lifecycle regressions plus an unchanged camera completion; independent F1 delta review passed. The two legacy roundtrip contracts now pass (2/2); typecheck, lint, format, build and typos exit 0 at 41314a2.

Exact-head validation at 41314a2: independent review CLEAR; CI passed 189/189 browser cases without retries and 1434 unit cases (6 expected failures, 2 skips). The legacy tests preserve exact state/identity and establish explicit provenance before testing absolute rotations.

Owner gates at merge: parent Core wstein/puzlwerk#85, license/distribution (EUPL-1.2 Core in the MIT app), physical-owner acceptance, M1 sequence per Cubistry #21.
Merge publishes: pages.yml deploys on every push to main, so merging ships the vendored EUPL-1.2 Core in the app bundle via GitHub Pages.
Blocker: None.

Private Core 0.1.0 is pinned to PuzlWerk source f7a0082fbb6683400cd8d34feed4cae36a8a5ba4 (an earlier #85 head; #61 replaces the pin). Recovery search is a separate follow-up. Physical-owner acceptance, complete NxN reachability and distribution/license approval remain open.

🤖 Generated with Claude Code

wstein and others added 4 commits November 17, 2026 00:07
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@wstein

wstein commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Review: FINDINGS head=ec92f3390fe00a01e2627c92057eea1b4d2f02c0 patch-id=5c155eac576751845414584010a076c49192e4dc pr=60
F1 (P1): delayed identity I/O can overwrite a newer capture session.
Single-photo repro: pause SHA-256, import a real 4x4 photo, close capture, select 5x5, release SHA; 0/6 becomes 1/6 in the new 5x5 session.
Fixture repro: pause the first identity digest during a 4x4 upload, select 5x5, release; the old upload restores 4x4/all six and opens approval.
Sources: useCaptureSession.ts:112-141; readFixtureUpload.ts:103; scannerUploadActions.ts:113-148.
Add a browser operation/session guard before accepting delayed results; stale message/next-face/error/finally/loading updates must also respect it.
This is I/O coordination, not a new puzzle rule or a request for a second engine.
Independent checks: 24 unit tests (9 provenance, 15 fixture) and six browser cases passed; five typechecked mutants failed at their intended assertions.
The seven original fixture files remain byte-identical; the vendored reviewed Core archive pin was verified.
Source tests ran on d1021da; its tree and this head both equal 33455f50c527afe97abdee50e8850e8e3523b631.
No other scoped source-identity/Core-boundary findings; physical/live acceptance and production-license gates remain separate.
Keep Draft pending F1 correction and exact-head checks; no merge or deployment approval.

wstein and others added 2 commits November 17, 2026 01:07
Co-Authored-By: Codex <noreply@openai.com>
@wstein

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Review: FINDINGS head=41314a27cfd972ede4a7961409f65d2a03c26b75 patch-id=09d300fbd88ed2b9cf5257aa8b1c991ec065530f pr=60
Scoped WI1/F1 integration and test-delta review is technically CLEAR; no open technical findings remain in that scope.
Original photo-ID/source projection and private Core archive pin checks remain applicable; no color-similarity source inference was added.
F1 fixed: canceled or superseded capture/import results, errors and finally/loading callbacks cannot overwrite a newer session.
Five new lifecycle cases passed independently; five typechecked counter-mutants failed at the intended Single/Fixture/Reset/Loading/Error assertions.
The legacy test delta preserves unknown provenance as null and establishes an explicit checked baseline before absolute-turn roundtrip checks.
Both changed browser cases passed independently; artificial export-pose and missing-baseline-proof mutants hit the new assertions directly.
Exact-head CI 43995715052 succeeded: 1434 unit tests passed, six expected failures, two skips; 189 browser tests passed with no retry/flaky entries.
Original seven-file fixture bytes, six distinct photo identities and reviewed package SHA were independently checked.
This is not a whole-plan approval: WI2 application work, Core source/parent gates, owner live acceptance and production-license/distribution gates remain separate.
Keep Draft while named gates remain; no Ready, merge, publication or production deployment approval is given.

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Cross-project architecture gate — 2026-11-17 (documentation only)

This photo-provenance fix and its pinned private PuzlWerk ReScript capture package are not evidence of an approved CubeAssembler M2 migration. The binding order remains Cubistry #21: independently accept the existing-solver 2×2 Counter M1 (ReScript core, separate TypeScript viewer, loadable/oriented sticker assets), then separately authorize CubeAssembler M2, then CubeLab M3.

The bounded Core capture implementation PuzlWerk #85 has its own explicit Draft-scope exception, but its stated terms do not authorize a consumer migration, publication or distribution. Before moving this Draft toward Ready/merge, document whether this narrow CubeAssembler capture fix is independently owner-authorized ahead of M1, and clear the already-listed physical acceptance, parent/Core, provenance and license/distribution gates. Preserve the working capture/renderer and this technical review evidence. No additional feature, dependency or merge is authorized by this note.

@wstein

wstein commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=41314a27cfd972ede4a7961409f65d2a03c26b75 patch-id=09d300fbd88ed2b9cf5257aa8b1c991ec065530f pr=60
Scope: exact head vs origin/main, 6 commits; no blocking findings. Prior F1 (late photo I/O) is fixed for single photo, fixture, solved/facelet reset, size change, retake, close, loading and error paths.
CI run 43995715052 attempt 1 success (typos, test incl. e2e). Local: typecheck, lint, format:check, typos, build exit 0; vitest 1380 pass, 47 fail only in 3 Git LFS JPEG suites (no LFS locally).
Local e2e 158/189; the 31 failures read LFS JPEGs or are timing, and the new lifecycle/provenance specs pass 9/9.
Mutations 13 typed: 10 killed at the intended test; 3 survivors are test gaps (nit).
Fixtures: existing fixtures byte-identical; new 4x4 ZIP entries match the owner originals 7/7; identity comes from Core provenance and JPEG hash, not colors.
Core pin 0.1.0 f7a0082 is replaced in #61; f7a0082 is not an ancestor of puzlwerk#85 head 46edbcf.
Nit: fixture-superseded-by-fixture loading release and importFiles stale error message have no test.
Nit: the guard after readFixtureUpload is only partly covered (stale "Detecting colors" message).
Nit: PR text needs "Blocker: None.", an "Owner gates at merge:" line and the Generated line last.
Fact for the owner gate: the Vite bundle contains EUPL-1.2 Core code and a push to main runs Publish Pages.
Rebase: mergeable clean, rebaseable true; all commits author and committer = repo identity; no session links.

@wstein
wstein marked this pull request as ready for review November 17, 2026 17:10
@wstein
wstein merged commit 0ca5f0f into main Nov 17, 2026
2 checks passed
@wstein
wstein deleted the fix/capture-photo-provenance branch November 17, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant