Skip to content

Add join support to ReadOnlyTabularStorage #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sroussey merged 2 commits into from
Sep 8, 2026
Merged

Add join support to ReadOnlyTabularStorage #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5549c07
feat: implement ITabularStorage.join for @workglow 0.5.0
claude Sep 5, 2026
cc4d33c
Merge remote-tracking branch 'origin/main' into claude/storage-layer-…
claude Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/storage/ReadOnlyTabularStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import type {
FromSchema,
InsertEntity,
ITabularStorage,
JoinedRow,
JoinSpec,
JoinType,
Page,
PageRequest,
QueryOptions,
Expand Down Expand Up @@ -121,6 +124,17 @@ export class ReadOnlyTabularStorage<
return this.inner.queryIndex(criteria, options);
}

/**
* A join is a read, so it forwards like every other read here. The write
* guard this wrapper exists for is unaffected: nothing in a join mutates.
*/
join<R, T extends JoinType>(
spec: JoinSpec<Entity, R, T>,
right: ITabularStorage<any, any, R, any, any>
): Promise<JoinedRow<Entity, R, T>[]> {
return this.inner.join(spec, right);
}

// ── transactions (no-op wrapper) ───────────────────────────────────
// Run `fn` against this read-only wrapper so writes inside continue to
// no-op; reads still hit the underlying storage. No real DB transaction
Expand Down