Add join support to ReadOnlyTabularStorage - #362
Merged
Conversation
`join` is a required member of ITabularStorage as of 0.5.0. This class implements the interface directly rather than extending BaseTabularStorage, so it does not inherit the default and must supply one. A join is a read, so it forwards to the inner storage like every other read here; the write guard this wrapper exists for is unaffected. The @workglow/cli pin moves to 0.5.0 in the same commit — the interface change is breaking, so the implementation and the version it requires have to land together. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HK4iHHRodgb3eLPCy7mcF2
…joins-v7mrh9 # Conflicts: # package.json
sroussey
added a commit
that referenced
this pull request
Sep 8, 2026
### Features - implement ITabularStorage.join for @WorkGlow 0.5.0 (#362) - implement CLI signal teardown and resource shutdown ### Bug Fixes - declare the embedding width beside the model instead of assuming it (#359) #### release - declare the runtime floor, and derive the release bump (#357) #### kb - stop --dry-run creating the index tables, and report them in db stats - bound `ask`'s implicit index, pin the embedding model, and let `db reset` drop the index #### ask - refuse rather than answer from model memory when nothing is retrieved #### adv - scope each Form ADV archive to its own folder and make ingest idempotent ### Performance #### status - read the newest ADV snapshot with one indexed row ### Tests #### coverage - make the README witness check capable of failing (#360) ### Chores - update deps - update dependencies to latest versions - migrate from Prettier to oxfmt for code formatting #### deps - upgrade Vitest to 5 (#342) ### Updated Dependencies - `@workglow/cli`: 0.5.0 - `typebox`: 1.3.29 - `workglow`: 0.5.0 - `@types/bun`: 1.4.2 - `bunset`: 1.1.1 - `oxlint`: ^1.82.0 - `vitest`: ^5.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
ReadOnlyTabularStorageto support join operations by forwarding them to the underlying storage, consistent with how other read operations are handled.Changes
joinmethod toReadOnlyTabularStoragethat forwards join requests to the inner storageJoinedRow,JoinSpec, andJoinTypeImplementation Details
The
joinmethod follows the same pattern as other read operations inReadOnlyTabularStorage(e.g.,query,queryIndex): it simply delegates tothis.inner.join(). Since joins do not mutate data, they are safe to expose through the read-only wrapper without compromising its write-protection guarantee.https://claude.ai/code/session_01HK4iHHRodgb3eLPCy7mcF2