Skip to content

chore(TMF-3812): drop the cloud run deploy steps #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muhammad-tahir-nawaz wants to merge 1 commit into
base: prod
Choose a base branch
from
Open

chore(TMF-3812): drop the cloud run deploy steps #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 3 additions & 29 deletions .github/workflows/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:
default: ""
type: string
deploy_type:
description: "Deployment target: gke | cloudrun-service | cloudrun-job | build-only | release-only"
description: "Deployment target: gke | build-only | release-only (anything else builds and pushes only)"
required: false
default: "gke"
type: string
Expand All @@ -38,7 +38,7 @@ on:
default: ""
type: string
cloudrun_name:
description: "Cloud Run service or job name (required if deploy_type != gke)"
description: "Ignored. Cloud Run is gone; kept until no caller branch passes it, then remove"
required: false
default: ""
type: string
Expand Down Expand Up @@ -125,10 +125,8 @@ jobs:
# reaches workloads without a pipeline:
#
# Keeper -> External Secrets Operator -> Kubernetes Secret -> envFrom (GKE)
# Keeper -> External Secrets Operator -> Kubernetes Secret -> terraform
# apply (modules/cloudrun-env-sync) -> Cloud Run env
#
# Both legs live in wanaware-infrastructure. CI plumbing (WIF identifiers,
# That path lives in wanaware-infrastructure. CI plumbing (WIF identifiers,
# registry host, GH_ACCESS_TOKEN) comes from the runner's Keeper-backed
# ci-workload env; nothing is a GitHub secret.
# ARC runners build through the pod's rootless BuildKit sidecar ($BUILDKIT_HOST):
Expand Down Expand Up @@ -208,30 +206,6 @@ jobs:
if: ${{ inputs.deploy_type == 'gke' }}
run: kubectl rollout restart deployment/${{ inputs.deployment_name }} -n ${{ inputs.namespace }}

# --- Cloud Run deploys ---
# Deliberately image-only: no --env-vars-file, ever. Cloud Run env vars are
# synced from the Keeper-backed Kubernetes Secret at terraform apply time
# (wanaware-infrastructure: modules/cloudrun-env-sync). `gcloud run deploy`
# and `gcloud run jobs update` preserve the env already on the resource when
# the flag is absent, so an image bump here never blanks it — whereas
# passing --env-vars-file replaces the whole environment, which is exactly
# the failure mode this removal prevents.
- name: Deploy Cloud Run service
if: ${{ inputs.deploy_type == 'cloudrun-service' }}
run: |
gcloud run deploy ${{ inputs.cloudrun_name }} \
--image ${{ env.GCP_REGISTRY }}/${{ env.GCP_PROJECT }}/${{ inputs.image_path }}:latest \
--region ${{ env.CLUSTER_REGION }} \
--project ${{ env.GCP_PROJECT }}

- name: Deploy Cloud Run job
if: ${{ inputs.deploy_type == 'cloudrun-job' }}
run: |
gcloud run jobs update ${{ inputs.cloudrun_name }} \
--image ${{ env.GCP_REGISTRY }}/${{ env.GCP_PROJECT }}/${{ inputs.image_path }}:latest \
--region ${{ env.CLUSTER_REGION }} \
--project ${{ env.GCP_PROJECT }}

# --- Optional: graphdoc generation ---
- name: Set up Go for private modules
if: ${{ inputs.generate_docs }}
Expand Down
Loading