Skip to content

chore(TMF-3812): drop the cloud run deploy steps - #61

Open
muhammad-tahir-nawaz wants to merge 1 commit into
prodfrom
chore/TMF-3812-drop-cloud-run-deploys
Open

muhammad-tahir-nawaz wants to merge 1 commit into
prodfrom
chore/TMF-3812-drop-cloud-run-deploys

Conversation

@muhammad-tahir-nawaz

Copy link
Copy Markdown
Contributor

Summary

Drop the Cloud Run deploy steps from the shared deployment workflow.

Why

Every workload that used Cloud Run now runs on GKE (wanaware-infrastructure #181, applied in dev, stage and prod). The Cloud Run services and jobs are deleted, so gcloud run jobs update fails and gcloud run deploy would recreate a service we no longer run.

Changes

  • Remove the "Deploy Cloud Run service" and "Deploy Cloud Run job" steps.
  • deploy_type lists only gke | build-only | release-only; any other value now builds and pushes only.
  • cloudrun_name is kept but ignored, so callers that still pass it don't fail on an unknown input.
  • Drop the cloudrun-env-sync leg from the Keeper comment.

Dependencies

  • wanaware-infrastructure #181

Notes for Reviewer

  • Still passing cloudrun-* today: subscription-manager stage/prod (payment-retry, subscription-billing, commission-reseller job workflows), worker-systems stage/prod (dlq-worker-task-failed), fleet-manager dev/stage/prod (ssh-service; removed in fleet-manager's own PR). Their dev branches are already build-only/gke. With this merged those runs just build and push the image, which is what the GKE CronJobs pull.
  • Remove cloudrun_name once those promotions land.

QA Report

N/A, workflow change only. YAML parses; no other workflow in this repo references Cloud Run.

Integration Tests

N/A

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge and matches the intended removal of Cloud Run deployment steps.

Summary

Removes Cloud Run deployment commands from .github/workflows/deployment.yaml.

  • Old Cloud Run targets now publish images without deploying them.

No actionable issues were found.

Reviews (1) · Last reviewed commit: "chore: drop the Cloud Run deploy steps" · Reviewed by Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the removal of obsolete Cloud Run deployment steps following the GKE migration.

No open issues 🎉

What changed in this PR

Removes obsolete Cloud Run deployment steps from the reusable deployment workflow following the migration to GKE, while preserving compatibility with callers that still pass legacy inputs.

Changes:

  • Removes Cloud Run service and job deployment commands.
  • Documents supported deployment targets and the build-and-push fallback; retains cloudrun_name as an ignored input.
  • Removes the obsolete Cloud Run environment-sync path from the Keeper comment.
File Description
.github/​workflows/​deployment.yaml Removes Cloud Run deployment steps and updates input descriptions and secret-sync comments.

Review effort: Balanced

This branch was successfully deployed

No deployments
development — 57b80eee Deployed Nov 11, 2026 by muhammad-tahir-nawaz via Run Trivy Scan and Go Tests #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants