Repository navigation
chore(TMF-3812): drop the cloud run deploy steps - #61
Open
muhammad-tahir-nawaz wants to merge 1 commit into
Open
muhammad-tahir-nawaz wants to merge 1 commit into
muhammad-tahir-nawaz wants to merge 1 commit into
Conversation
muhammad-tahir-nawaz
had a problem deploying
to
development
November 11, 2026 10:08 — with
GitHub Actions
Error
Contributor
[Medium impact] The PR appears safe to merge and matches the intended removal of Cloud Run deployment steps. SummaryRemoves Cloud Run deployment commands from
No actionable issues were found. Reviews (1) · Last reviewed commit: "chore: drop the Cloud Run deploy steps" · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the removal of obsolete Cloud Run deployment steps following the GKE migration.
No open issues 🎉
What changed in this PR
Removes obsolete Cloud Run deployment steps from the reusable deployment workflow following the migration to GKE, while preserving compatibility with callers that still pass legacy inputs.
Changes:
- Removes Cloud Run service and job deployment commands.
- Documents supported deployment targets and the build-and-push fallback; retains
cloudrun_nameas an ignored input. - Removes the obsolete Cloud Run environment-sync path from the Keeper comment.
| File | Description |
|---|---|
.github/workflows/deployment.yaml |
Removes Cloud Run deployment steps and updates input descriptions and secret-sync comments. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the Cloud Run deploy steps from the shared deployment workflow.
Why
Every workload that used Cloud Run now runs on GKE (wanaware-infrastructure #181, applied in dev, stage and prod). The Cloud Run services and jobs are deleted, so
gcloud run jobs updatefails andgcloud run deploywould recreate a service we no longer run.Changes
deploy_typelists onlygke | build-only | release-only; any other value now builds and pushes only.cloudrun_nameis kept but ignored, so callers that still pass it don't fail on an unknown input.Dependencies
Notes for Reviewer
cloudrun-*today: subscription-manager stage/prod (payment-retry, subscription-billing, commission-reseller job workflows), worker-systems stage/prod (dlq-worker-task-failed), fleet-manager dev/stage/prod (ssh-service; removed in fleet-manager's own PR). Their dev branches are alreadybuild-only/gke. With this merged those runs just build and push the image, which is what the GKE CronJobs pull.cloudrun_nameonce those promotions land.QA Report
N/A, workflow change only. YAML parses; no other workflow in this repo references Cloud Run.
Integration Tests
N/A