Skip to content

chore: pass GIT_SHA as an image build arg #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muhammad-tahir-nawaz merged 1 commit into from
Nov 10, 2026
Merged

chore: pass GIT_SHA as an image build arg #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ jobs:
tags: ${{ env.GCP_REGISTRY }}/${{ env.GCP_PROJECT }}/${{ inputs.image_path }}:latest
build-args: |
GH_ACCESS_TOKEN=${{ env.GH_ACCESS_TOKEN }}
GIT_SHA=${{ github.sha }}

- name: Run Trivy vulnerability scanner on image
if: ${{ inputs.deploy_type != 'release-only' }}
Expand All @@ -187,6 +188,7 @@ jobs:
tags: ${{ env.GCP_REGISTRY }}/${{ env.GCP_PROJECT }}/${{ inputs.image_path }}:latest
build-args: |
GH_ACCESS_TOKEN=${{ env.GH_ACCESS_TOKEN }}
GIT_SHA=${{ github.sha }}

# --- GKE deploy ---
- name: Get GKE Credentials
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/shared-registry-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ jobs:
${{ env.GCP_REGISTRY_SHARED }}/${{ env.GCP_PROJECT_SHARED }}/wanaware-platform/${{ inputs.image_path }}:${{ steps.timestamp.outputs.value }}
build-args: |
GH_ACCESS_TOKEN=${{ env.GH_ACCESS_TOKEN }}
GIT_SHA=${{ github.sha }}

# Surface the result. Because the push is best-effort, the job goes green
# even when it fails, so without an explicit warning a stale shared
Expand Down
Loading