Repository navigation
chore: pass GIT_SHA as an image build arg - #60
Merged
Merged
Conversation
muhammad-tahir-nawaz
had a problem deploying
to
development
November 10, 2026 07:09 — with
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change passing the caller’s commit SHA to image builds.
No open issues 🎉
What changed in this PR
Passes the caller’s commit SHA to image builds so aws-integrator can populate its Tier 0 seed_version.
Changes:
- Adds
GIT_SHA=${{ github.sha }}to both deployment image build steps. - Supplies the same build argument to the shared-registry image build.
| File | Description |
|---|---|
.github/workflows/shared-registry-push.yaml |
Passes GIT_SHA to the shared-registry build. |
.github/workflows/deployment.yaml |
Passes GIT_SHA to the deployment build and push steps. |
Review effort: Balanced
Contributor
[Medium impact] This PR appears safe to merge. SummaryPasses
Reviews (1) · Last reviewed commit: "chore: pass GIT_SHA as an image build ar..." · Reviewed by Greptile |
maira-ayub
approved these changes
Nov 10, 2026
mirwaleed
approved these changes
Nov 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass
GIT_SHA=${{ github.sha }}as a build arg in every image build: the deploy build and push indeployment.yaml, and the shared registry push inshared-registry-push.yamlso that image stays identical to the one we deploy. In a reusable workflowgithub.shais the caller's commit.Dockerfiles that don't declare
ARG GIT_SHAignore it, so other services build exactly as before (no cache change).Why
aws-integrator stamps
seed_versionon its Tier 0 resource mapping fromGIT_SHA(VELT-915, already on aws-integrator dev). Without this arg the image builds with an empty version and Tier 0 has noseed_version.QA Report
Integration Tests
Dependencies
None. aws-integrator's Dockerfile already declares
ARG GIT_SHA; its next dev deploy picks this up.