Skip to content

chore: pass GIT_SHA as an image build arg - #60

Merged
muhammad-tahir-nawaz merged 1 commit into
prodfrom
chore/pass-git-sha-build-arg
Nov 10, 2026
Merged

muhammad-tahir-nawaz merged 1 commit into
prodfrom
chore/pass-git-sha-build-arg

Conversation

@muhammad-tahir-nawaz

Copy link
Copy Markdown
Contributor

Summary

Pass GIT_SHA=${{ github.sha }} as a build arg in every image build: the deploy build and push in deployment.yaml, and the shared registry push in shared-registry-push.yaml so that image stays identical to the one we deploy. In a reusable workflow github.sha is the caller's commit.

Dockerfiles that don't declare ARG GIT_SHA ignore it, so other services build exactly as before (no cache change).

Why

aws-integrator stamps seed_version on its Tier 0 resource mapping from GIT_SHA (VELT-915, already on aws-integrator dev). Without this arg the image builds with an empty version and Tier 0 has no seed_version.

QA Report

  • No QA report required

Integration Tests

  • No integration tests required

Dependencies

None. aws-integrator's Dockerfile already declares ARG GIT_SHA; its next dev deploy picks this up.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the change passing the caller’s commit SHA to image builds.

No open issues 🎉

What changed in this PR

Passes the caller’s commit SHA to image builds so aws-integrator can populate its Tier 0 seed_version.

Changes:

  • Adds GIT_SHA=${{ github.sha }} to both deployment image build steps.
  • Supplies the same build argument to the shared-registry image build.
File Description
.github/​workflows/​shared-registry-push.yaml Passes GIT_SHA to the shared-registry build.
.github/​workflows/​deployment.yaml Passes GIT_SHA to the deployment build and push steps.

Review effort: Balanced

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Passes GIT_SHA=${{ github.sha }} to all three image builds.

  • Image builds now receive the caller's commit SHA.

Reviews (1) · Last reviewed commit: "chore: pass GIT_SHA as an image build ar..." · Reviewed by Greptile

@muhammad-tahir-nawaz
muhammad-tahir-nawaz merged commit 76c866f into prod Nov 10, 2026
4 of 5 checks passed
@muhammad-tahir-nawaz
muhammad-tahir-nawaz deleted the chore/pass-git-sha-build-arg branch November 10, 2026 07:25

This branch was successfully deployed

No deployments
development — 3d25e4ad Deployed Nov 10, 2026 by muhammad-tahir-nawaz via Run Trivy Scan and Go Tests #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants