Skip to content

duckdb: don't optimize_recursive() before exporting chunks #9795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myrrc merged 2 commits into from
Sep 10, 2026
Merged

duckdb: don't optimize_recursive() before exporting chunks #9795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5e3c7
duckdb: don't optimize_recursive() before exporting chunks
myrrc Sep 8, 2026
0186b46
fix
myrrc Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions vortex-duckdb/src/table_function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,8 @@ use vortex::aggregate_fn::DynAccumulator;
use vortex::array::ArrayRef;
use vortex::array::Canonical;
use vortex::array::ExecutionCtx;
use vortex::array::arrays::ScalarFn;
use vortex::array::arrays::Struct;
use vortex::array::arrays::StructArray;
use vortex::array::arrays::scalar_fn::ScalarFnArrayExt;
use vortex::array::optimizer::ArrayOptimizer;
use vortex::dtype::DType;
use vortex::dtype::PType;
use vortex::error::VortexExpect;
Expand All @@ -36,7 +33,6 @@ use vortex::metrics::tracing::get_global_labels;
use vortex::scalar::Scalar;
use vortex::scalar_fn::fns::binary::Binary;
use vortex::scalar_fn::fns::operators::Operator;
use vortex::scalar_fn::fns::pack::Pack;
use vortex_utils::aliases::hash_map::HashMap;

use crate::convert::PushedAggregate;
Expand Down Expand Up @@ -378,20 +374,12 @@ pub(crate) fn optimize_and_bind(expr: Expression, dtype: &DType) -> VortexResult
}

pub(crate) fn convert_result(array: ArrayRef, ctx: &mut ExecutionCtx) -> VortexResult<StructArray> {
let array_result = array.optimize_recursive(ctx.session())?;
Ok(if let Some(array) = array_result.as_opt::<Struct>() {
// By the time we got here, array is fully optimized, don't call
// optimize_recursive or similar functions here.
Ok(if let Some(array) = array.as_opt::<Struct>() {
array.into_owned()
} else if let Some(array) = array_result.as_opt::<ScalarFn>()
&& let Some(pack_options) = array.scalar_fn().as_opt::<Pack>()
{
StructArray::new(
pack_options.names.clone(),
array.children(),
array.len(),
pack_options.nullability.into(),
)
} else {
array_result.execute::<Canonical>(ctx)?.into_struct()
array.execute::<Canonical>(ctx)?.into_struct()
})
}

Expand Down
Loading