Skip to content

Fix AbortError when playing tweet videos under Strict Mode #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShobhanKarthish wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

Fix AbortError when playing tweet videos under Strict Mode #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/react-tweet/src/twitter-theme/tweet-media-video.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client'

import { useState } from 'react'
import { useRef, useState } from 'react'
import clsx from 'clsx'
import type { MediaAnimatedGif, MediaVideo } from '../api/index.js'
import {
Expand All @@ -21,12 +21,14 @@ export const TweetMediaVideo = ({ tweet, media }: Props) => {
const [playButton, setPlayButton] = useState(true)
const [isPlaying, setIsPlaying] = useState(false)
const [ended, setEnded] = useState(false)
const videoRef = useRef<HTMLVideoElement>(null)
const mp4Video = getMp4Video(media)
let timeout = 0

return (
<>
<video
ref={videoRef}
className={mediaStyles.image}
poster={getMediaUrl(media, 'small')}
controls={!playButton}
Expand Down Expand Up @@ -60,10 +62,12 @@ export const TweetMediaVideo = ({ tweet, media }: Props) => {
className={s.videoButton}
aria-label="View video on X"
onClick={(e) => {
const video = e.currentTarget.previousSibling as HTMLMediaElement

e.preventDefault()
setPlayButton(false)

const video = videoRef.current
if (!video) return

video.load()
video
.play()
Expand All @@ -72,6 +76,9 @@ export const TweetMediaVideo = ({ tweet, media }: Props) => {
video.focus()
})
.catch((error) => {
// AbortError is expected when the element is briefly removed
// (e.g. React Strict Mode remounts) while play() is in flight.
if (error?.name === 'AbortError') return
console.error('Error playing video:', error)
setPlayButton(true)
setIsPlaying(false)
Expand Down