Fix AbortError when playing tweet videos under Strict Mode - #224
Open
ShobhanKarthish wants to merge 1 commit into
Open
Fix AbortError when playing tweet videos under Strict Mode#224ShobhanKarthish wants to merge 1 commit into
ShobhanKarthish wants to merge 1 commit into
Conversation
Keep a stable videoRef instead of reading previousSibling after the play button unmounts, and ignore AbortError from interrupted play().
Contributor
|
@ShobhanKarthish is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playing a tweet video in React Strict Mode (dev) can log:
The play button handler was grabbing the video via
previousSibling, then callingsetPlayButton(false). That unmounts the button and can leaveplay()racing a remount, which surfaces as an AbortError even though playback often still works on retry.This change:
videoRefon the<video>element and uses that instead ofpreviousSiblingAbortErrorin the.catchso expected interruptions from remounts don’t spam the consoleTest plan
2006254902629044564) with React Strict Mode onCloses #213