Skip to content

Enhance menu bar documentation on icons and variants #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodolforfq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance menu bar documentation on icons and variants #5447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions articles/components/menu-bar/index.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ include::{root}/frontend/demo/component/menubar/react/menu-bar-icons.tsx[render,
endif::[]
--

Most actions are difficult to represent reliably with icons, so use them sparingly. The benefit of icons in addition to text should be weighed against the visual distractions they may create. Menu items in drop-down menus should always have text labels.
Most actions are difficult to represent reliably with icons, so use them sparingly. The benefit of icons in addition to text should be weighed against the visual distractions they may create. Menu items in drop-down menus should always have text labels. Top-level items that open a drop-down menu are easier to recognize with the <<styling#drop-down-indicators,`dropdown-indicators`>> theme variant.

Icon-only menu buttons should be used primarily for common recurring actions with highly standardized, universally understood icons. Menu buttons should include a textual alternative for screen readers using the `aria-label` attribute or <<tooltips,tooltips>>. Menu Bars with icon-only top-level items can use the *Tertiary Inline* style variant (Lumo only) to reduce the horizontal padding around the icons.
Icon-only menu buttons should be used primarily for common recurring actions with highly standardized, universally understood icons. Menu buttons should include a textual alternative for screen readers using the `aria-label` attribute or <<tooltips,tooltips>>. Menu Bars with icon-only top-level items can use the *Tertiary Inline* style variant or the `icon` theme variant (both Lumo only) to reduce the horizontal padding around the icons. The `icon` variant also hides drop-down indicators, even when the `dropdown-indicators` variant is applied, so avoid combining the two if the indicators are needed.

[.example]
--
Expand Down
Loading