Skip to content

Enhance menu bar documentation on icons and variants#5447

Open
rodolforfq wants to merge 1 commit into
mainfrom
menu-items-icons-variants
Open

Enhance menu bar documentation on icons and variants#5447
rodolforfq wants to merge 1 commit into
mainfrom
menu-items-icons-variants

Conversation

@rodolforfq

Copy link
Copy Markdown
Contributor

Added guidance on using MenuBarVariant for drop-down indicators and icon-only menu items. Based con customer's feedback.

@CLAassistant

CLAassistant commented Apr 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

AI Language Review

  • In the "Menu Item Features" section, consider clarifying the description of the icon theme variant. The explanation should explicitly state that the variant not only reduces padding but also affects the visibility of drop-down indicators when combined with the dropdown-indicators variant. This will ensure users clearly understand the variant's effects.
  • In the "Icons" sub-section of the "Menu Item Features" section, use consistent terminology for "drop-down indicator" across the document to improve clarity.

No other issues requiring improvement were identified in the modified content of the file.

@jouni jouni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure I follow the logic implied by the additional sentences. In what cases should drop-down indicators be used? And I don't think the LUMO_ICON variant hides the drop-down indicators.

Also, as the guidance here is Lumo-specific and doesn't apply to base styles or Aura at all, I would like to avoid theme-specific guidance in the main component docs page. Theme-specific things would be more suitable on the Styling sub-page.

Based con customer's feedback.

What was the feedback?

@StefanPenndorf

Copy link
Copy Markdown

Hi @jouni ,

in a Vaadin 24 application I tried to combine MenuBarVariant.LUMO_ICON with MenuBarVariant.LUMO_DROPDOWN_INDICATORS. The MenuBar should consist of a single main item that provides three options via Drop-Down. The main item has an Icon as well as the drop down indicator:

image

Adding both variants MenuBarVariant.LUMO_ICON and MenuBarVariant.LUMO_DROPDOWN_INDICATORS did remove the drop down indicator. The example for MenuBarVariant.LUMO_ICON in the Vaadin docs useses MenuBar items with and without additional text on the Button and let me think this applies to my use case as well. It wasn't clear to me that MenuBarVariant.LUMO_ICON is intended for icon-only items / icon-bar-items. It wasn't clear to me that it doesn't work with MenuBarVariant.LUMO_DROPDOWN_INDICATORS and beyond that only reduces spacing. The latter was important for my assessment / descission to not use MenuBarVariant.LUMO_ICON (without negative consequences).

Does this help to clarify?

@jouni

jouni commented Apr 10, 2026

Copy link
Copy Markdown
Member

Thanks, that helps to clarify where the documentation is unclear. I’ll try to phrase the update more clearly based on that.

@Artur- Artur- changed the base branch from v24 to main June 12, 2026 16:44
Rephrase the added guidance to use framework-neutral theme variant
names consistent with the rest of the page, link to the Drop-down
Indicators section, and clarify that the icon variant is meant for
icon-only top-level items and suppresses drop-down indicators even
when the dropdown-indicators variant is applied (per PR feedback).
@Artur- Artur- force-pushed the menu-items-icons-variants branch from f74f315 to 96a8285 Compare June 12, 2026 16:49
@Artur- Artur- enabled auto-merge (squash) June 12, 2026 16:50
@github-actions

Copy link
Copy Markdown

Preview Deployment

This PR has been deployed for preview.

URL: https://docs-preview-pr-5447.fly.dev

Built from b85f902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants