Enhance menu bar documentation on icons and variants#5447
Conversation
AI Language Review
No other issues requiring improvement were identified in the modified content of the file. |
jouni
left a comment
There was a problem hiding this comment.
I’m not sure I follow the logic implied by the additional sentences. In what cases should drop-down indicators be used? And I don't think the LUMO_ICON variant hides the drop-down indicators.
Also, as the guidance here is Lumo-specific and doesn't apply to base styles or Aura at all, I would like to avoid theme-specific guidance in the main component docs page. Theme-specific things would be more suitable on the Styling sub-page.
Based con customer's feedback.
What was the feedback?
|
Hi @jouni , in a Vaadin 24 application I tried to combine
Adding both variants Does this help to clarify? |
|
Thanks, that helps to clarify where the documentation is unclear. I’ll try to phrase the update more clearly based on that. |
Rephrase the added guidance to use framework-neutral theme variant names consistent with the rest of the page, link to the Drop-down Indicators section, and clarify that the icon variant is meant for icon-only top-level items and suppresses drop-down indicators even when the dropdown-indicators variant is applied (per PR feedback).
f74f315 to
96a8285
Compare
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-5447.fly.dev Built from b85f902 |

Added guidance on using MenuBarVariant for drop-down indicators and icon-only menu items. Based con customer's feedback.