Skip to content

fix: avoid xattr on unsupported platforms - #14652

Merged
sylvestre merged 5 commits into
uutils:mainfrom
xtqqczze:deps/xattr
Sep 18, 2026
Merged

sylvestre merged 5 commits into
uutils:mainfrom
xtqqczze:deps/xattr

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

The xattr crate enables a default feature for unsupported Unix platforms. That is, it builds on all Unix platforms but always fails at runtime on unsupported Unix platforms.

Disable the default features so xattr does not build on unsupported platforms.

Closes #14642
Closes #14647
Closes #14658

@xtqqczze
xtqqczze marked this pull request as draft September 17, 2026 17:31
@xtqqczze xtqqczze changed the title fix: disable xattr on unsupported platforms uucore: disable fsxattr on unsupported platforms Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)

@codspeed

codspeed Bot commented Sep 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 97 untouched benchmarks
⏩ 320 skipped benchmarks1


Comparing xtqqczze:deps/xattr (c364534) with main (1aa8780)2

Open in CodSpeed

Footnotes

  1. 320 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (9bab5f1) during the generation of this report, so 1aa8780 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@xtqqczze
xtqqczze force-pushed the deps/xattr branch 3 times, most recently from 16c6c00 to 25e5bba Compare September 17, 2026 19:08
@xtqqczze
xtqqczze force-pushed the deps/xattr branch 3 times, most recently from 6101ec2 to c15c481 Compare September 17, 2026 21:18
The `xattr` crate enables a default feature for unsupported Unix platforms. That is, it builds on all Unix platforms but always fails at runtime on unsupported Unix platforms.

Disable the default features so `xattr` does not build on unsupported platforms.
@xtqqczze xtqqczze changed the title uucore: disable fsxattr on unsupported platforms fix: avoid xattr on unsupported platforms Sep 17, 2026
@xtqqczze
xtqqczze marked this pull request as ready for review September 17, 2026 22:43
@krosci

krosci commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Cutting OpenBSD is not the best solution.

Please see #14658 (comment)

@sylvestre
sylvestre merged commit e25efcb into uutils:main Sep 18, 2026
128 of 177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_cp_attributes_only_fifo_keeps_type_and_returns fails on OpenBSD

3 participants