Skip to content

cp: disable test on OpenBSD & add todo - #14647

Closed
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:cp_disable_test_on_openbsd
Closed

cp: disable test on OpenBSD & add todo#14647
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:cp_disable_test_on_openbsd

Conversation

@cakebaker

@cakebaker cakebaker commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

This PR disables the new test test_cp_attributes_only_fifo_keeps_type_and_returns on OpenBSD and adds a todo.

Fixes #14642

@cakebaker
cp: disable test on OpenBSD & add todo
26088e4 
affected test: test_cp_attributes_only_fifo_keeps_type_and_returns
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@oech3 oech3 mentioned this pull request Sep 17, 2026
Closed
xtqqczze
xtqqczze reviewed Sep 17, 2026
View reviewed changes
Comment thread tests/by-util/test_cp.rs
/// forever, since nothing ever writes to it. GNU creates the FIFO and returns.
#[test]
#[cfg(unix)]
// TODO remove when https://github.com/Stebalien/xattr/issues/121 is fixed

@xtqqczze xtqqczze Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make no representation that Stebalien/xattr#121 is actually fixable...

@xtqqczze

xtqqczze commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

The real issue is that the xattr crate is unsupported on OpenBSD and always errors, it would be better to exclude this at compile time: #14652.

@xtqqczze

xtqqczze commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cakebaker I've got no objection if you you want to merge this for now to unblock CI, but #14652 will fix the root cause instead.

This was referenced Sep 17, 2026
Merged
Closed
@cakebaker
cakebaker deleted the cp_disable_test_on_openbsd branch September 18, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xtqqczze xtqqczze xtqqczze left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_cp_attributes_only_fifo_keeps_type_and_returns fails on OpenBSD

2 participants

@cakebaker @xtqqczze