Revert "Speed up external"

[utkarshdalal]

Reverts #1773

---

Summary by cubic

Reverts the external storage speed-up and restores installs to app-specific Android/data paths. Removes public install root logic, related migrations, and the /storage/-based env tweak; resets image FS version to 28.

• Refactors
  • Use only app-specific external files dirs; stop mapping to a public GameNative root or migrating prefs/dirs.
  • Simplify settings to store the exact selected external path; remove dual-path matching.
  • Remove FFP_ENABLE env toggle tied to /storage/ paths.
  • Drop public/migration helpers in StorageUtils and use original game folder paths for drive mapping.
  • Set ImageFsInstaller.LATEST_VERSION back to 28.

^{Written for commit bb1c6dc. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Improved detection and selection of external storage volumes.
  • Simplified game installation and container drive path handling for more reliable access.
  • Improved compatibility by enabling Wine synchronization when needed.
  • Removed unsupported frame-rate environment overrides that could affect game behavior.
• Maintenance
  • Updated the bundled runtime image and related redirect data.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ae4ff67-d71c-49a1-9034-4a28ac12551c

📥 Commits

Reviewing files that changed from the base of the PR and between a5d0c28 and bb1c6dc.

⛔ Files ignored due to path filters (1)

• app/src/modern/assets/libredirect-bionic-wx.so is excluded by !**/*.so

📒 Files selected for processing (7)

• app/src/main/assets/redirect.tzst
• app/src/main/java/app/gamenative/service/DownloadService.kt
• app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInterface.kt
• app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
• app/src/main/java/app/gamenative/utils/ContainerUtils.kt
• app/src/main/java/app/gamenative/utils/StorageUtils.kt
• app/src/main/java/com/winlator/xenvironment/ImageFsInstaller.java

---

📝 Walkthrough

Walkthrough

External storage paths now use mounted volume directories directly, legacy migration helpers were removed, container A-drive mapping follows the raw game path, runtime environment defaults changed, and image filesystem assets were updated.

Changes

External storage path handling

Layer / File(s)	Summary
Direct external volume paths app/src/main/java/app/gamenative/utils/StorageUtils.kt, app/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInterface.kt, app/src/main/java/app/gamenative/service/DownloadService.kt	Legacy public-root and migration helpers were removed. Settings and download service logic now use mounted external volume absolutePath values directly.
Container A drive mapping app/src/main/java/app/gamenative/utils/ContainerUtils.kt	Container creation checks and writes the A: drive mapping using gameFolderPath directly.

Runtime and image updates

Layer / File(s)	Summary
X server environment setup app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt	DXVK_FRAME_RATE and VKD3D_FRAME_RATE are removed, WINEESYNC defaults to 1, and FFP_ENABLE injection was removed.
Image filesystem and redirect payload app/src/main/java/com/winlator/xenvironment/ImageFsInstaller.java, app/src/main/assets/redirect.tzst	The image filesystem version gate changed from 29 to 28, and the compressed redirect asset was replaced.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• utkarshdalal/GameNative#1773: Touches the same storage migration, container mapping, and X server environment paths in the opposite direction.
• utkarshdalal/GameNative#1476: Overlaps with external-storage volume selection and PrefManager.externalStoragePath handling.
• utkarshdalal/GameNative#390: Modifies container A: drive remapping logic.

Suggested reviewers: phobos665

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-1773-speed-up-external

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}