Skip to content

Fixed external bug for redist folders not showing - #1780

Merged
utkarshdalal merged 4 commits into
masterfrom
speed-up-external
Jul 29, 2026
Merged

Fixed external bug for redist folders not showing#1780
utkarshdalal merged 4 commits into
masterfrom
speed-up-external

Conversation

@utkarshdalal

@utkarshdalal utkarshdalal commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Description

Previous build of shim cached folders including redist folders. Fixed here.

Recording

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Fixes hidden external "redist" folders by updating the redirect shim and bumping the image FS version to 30 to invalidate stale caches.

  • Bug Fixes
    • Updated redirect assets (redirect.tzst, libredirect-bionic-wx.so) so directory listings no longer hide external folders.
    • Bumped ImageFsInstaller.LATEST_VERSION to 30 to ensure existing containers pick up the new shim.

Written for commit ead0252. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Updated the bundled image filesystem asset.
    • Improved installation checks to recognize the latest image filesystem version.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 414b178e-ea6b-4113-b349-bc997dd4d9af

📥 Commits

Reviewing files that changed from the base of the PR and between 60c54e5 and ead0252.

⛔ Files ignored due to path filters (1)
  • app/src/modern/assets/libredirect-bionic-wx.so is excluded by !**/*.so
📒 Files selected for processing (2)
  • app/src/main/assets/redirect.tzst
  • app/src/main/java/com/winlator/xenvironment/ImageFsInstaller.java

📝 Walkthrough

Walkthrough

The image filesystem installer now recognizes version 30 as latest, and the bundled redirect.tzst compressed asset was fully regenerated.

Changes

Image filesystem refresh

Layer / File(s) Summary
Versioned image filesystem update
app/src/main/java/com/winlator/xenvironment/ImageFsInstaller.java, app/src/main/assets/redirect.tzst
LATEST_VERSION changes from 29 to 30, and the compressed redirect asset is replaced with regenerated contents.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the main change: fixing redist folders not showing.
Description check ✅ Passed The description mostly follows the template, but the Recording section is still empty.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch speed-up-external

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@utkarshdalal
utkarshdalal merged commit d61318b into master Jul 29, 2026
3 checks passed
@utkarshdalal
utkarshdalal deleted the speed-up-external branch July 29, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant