Adopt rtichoke_viz v0.4.0 and enable browser Lift - #382
Merged
Conversation
Contributor
|
uriahf
marked this pull request as ready for review
August 23, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtichoke_viz v0.4.0release artifactrenderer="browser"/"rtichoke_viz"Immutable release
v0.4.02125c7099839cadd536c6f38f3f7e23a17ca4348rtichoke-viz-0.4.0.tar.gz9a687cd938f1875d577e592664ca75447455166169f6132dd7f79406515e14e1The vendoring test verifies the archive checksum, exact archive member set, schema IDs, required existing exports,
renderLiftV2, and byte-for-byte equality between the vendored JS/CSS/schema files and the copies inside the immutable release archive.Browser Lift activation
RtichokeBrowserChart.write_html()already dispatches Lift specs torenderLiftV2. This PR removes only the temporary Lift browser rejection in_render_lift_v2()and returns the normalRtichokeBrowserChartforbrowser/rtichoke_viz.No Lift statistics, canonical spec builders, reference ownership, deterministic IDs, Plotly default behavior, Matplotlib behavior, or public APIs are changed.
Tests / checks
ty check src/rtichokerenderLiftV2, while retaining Plotly-default and Matplotlib assertionsDo not merge automatically.