Skip to content

Commit e99fffc

Browse files
authored
Merge pull request #382 from uriahf/feat/browser-lift-v0.4.0
Adopt rtichoke_viz v0.4.0 and enable browser Lift
2 parents d5b7f67 + f645329 commit e99fffc

10 files changed

Lines changed: 726 additions & 52 deletions

src/rtichoke/_renderers.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,5 @@ def _render_lift_v2(
303303
if selected == "matplotlib":
304304
return _render_lift_matplotlib(spec, size=size, color_values=color_values)
305305
if selected in {"browser", "rtichoke_viz"}:
306-
raise ValueError(
307-
"Browser rendering for Lift curves requires a newer vendored release of rtichoke_viz containing Lift support."
308-
)
306+
return RtichokeBrowserChart(spec=spec, size=size)
309307
raise ValueError("The Plotly renderer must use the existing production path.")
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
Vendored from the immutable rtichoke_viz release recorded in VENDORED_FROM.
22
The JS/CSS and both schema files are copied byte-for-byte from that release archive.
3-
Production browser integration remains on the existing v1 spec until a separate adoption change.
3+
Browser integrations use only renderer exports present in the recorded immutable release.
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
repository=https://github.com/uriahf/rtichoke_viz
2-
release=v0.3.1
3-
source_commit=5ccde928a0bf9fa6ece2b7572687b442c57a98a9
4-
archive=rtichoke-viz-0.3.1.tar.gz
5-
sha256=121aa8eb8d0f8427ecfb2c01dab0fb05668eaedf47ddcfc0cd282a7ecf1ce448
6-
2+
release=v0.4.0
3+
source_commit=2125c7099839cadd536c6f38f3f7e23a17ca4348
4+
archive=rtichoke-viz-0.4.0.tar.gz
5+
sha256=9a687cd938f1875d577e592664ca75447455166169f6132dd7f79406515e14e1
-147 KB
Binary file not shown.
148 KB
Binary file not shown.

0 commit comments

Comments
 (0)