Skip to content

Enforce Ruff lint in package CI #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uriahf merged 4 commits into from
Aug 20, 2026
Merged

Enforce Ruff lint in package CI #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fae24d
ci: enforce Ruff checks
uriahf Aug 20, 2026
b3f7426
chore: remove unused gains import
uriahf Aug 20, 2026
07e86e2
chore: remove unused test import
uriahf Aug 20, 2026
2d83cdd
ci: keep Ruff lint-only in baseline PR
uriahf Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ jobs:
- name: Install the project
run: uv sync --all-extras --dev

- name: Check lint
run: uv run ruff check .

- name: Build package
run: uv build

Expand Down
1 change: 0 additions & 1 deletion src/rtichoke/discrimination/gains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from plotly.graph_objs._figure import Figure
from rtichoke.processing.binary_color_values import _apply_color_values_binary
from rtichoke.processing.plotly_helper_functions import (
_create_rtichoke_plotly_curve_times,
_create_rtichoke_plotly_curve_binary,
_plot_rtichoke_curve_binary,
_create_rtichoke_curve_list_times,
Expand Down
5 changes: 1 addition & 4 deletions tests/test_decision_curve_dcurves_parity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

from importlib import resources

import numpy as np
import polars as pl
from dcurves import dca
from numpy.testing import assert_allclose
Expand Down Expand Up @@ -40,9 +39,7 @@ def _dcurves_survival_dca(data: pl.DataFrame, thresholds: list[float]):
# dcurves requires a pandas DataFrame and already depends on pandas itself.
# Building it from plain Python data avoids adding pyarrow just for
# `pl.DataFrame.to_pandas()`.
pandas_df_type = type(
dca.__globals__["pd"].DataFrame()
)
pandas_df_type = type(dca.__globals__["pd"].DataFrame())
pandas_data = pandas_df_type(data.to_dict(as_series=False))

return dca(
Expand Down
Loading