Skip to content

[hypertable] Updated date format in cell renderer #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathalieArnoux wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

[hypertable] Updated date format in cell renderer #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e67d42
Updated date format in cell renderer
nathalieArnoux Aug 5, 2026
5138074
Fixed format to follow inbox sidepanel format
nathalieArnoux Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/components/hyper-table-v2/cell-renderers/date.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ interface HyperTableV2RenderersDateArgs {
extra?: { [key: string]: any };
}

const DEFAULT_DATE_FORMAT = 'MMMM D, YYYY';
const DEFAULT_DATE_FORMAT = 'MMM DD, YYYY';

export default class HyperTableV2CellRenderersDate extends Component<HyperTableV2RenderersDateArgs> {
get value() {
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/components/hyper-table-v2/cell-renderers/date-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module('Integration | Component | hyper-table-v2/cell-renderers/date', function

assert.equal(this.column.definition.key, 'date');
assert.equal(this.row[this.column.definition.key], '1643386394');
assert.dom().hasText('January 28, 2022');
assert.dom().hasText('Jan 28, 2022');

@edouardmisset edouardmisset Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: following your screenshot, shouldn't there be a period (".") after the month? If so it's weird that the test passes as is (IMO it would be worth tightening).

Suggested change
assert.dom().hasText('Jan 28, 2022');
assert.dom().hasText('Jan. 28, 2022');

@nathalieArnoux nathalieArnoux Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshot is not up-to-date, I will update it when possible. Thanks for letting me know :)

});

test('it renders a default - when the value is null', async function (this: TestContext, assert) {
Expand Down
Loading