[hypertable] Updated date format in cell renderer - #273
Open
nathalieArnoux wants to merge 2 commits into
Open
Conversation
nathalieArnoux
requested review from
Elodie-DeMatteis-Upf and
olxmpe
and removed request for
a team
August 5, 2026 15:12
nathalieArnoux
changed the title
OwenCoogan
approved these changes
Aug 6, 2026
edouardmisset
approved these changes
Aug 11, 2026
| assert.equal(this.column.definition.key, 'date'); | ||
| assert.equal(this.row[this.column.definition.key], '1643386394'); | ||
| assert.dom().hasText('January 28, 2022'); | ||
| assert.dom().hasText('Jan 28, 2022'); |
Contributor
There was a problem hiding this comment.
question: following your screenshot, shouldn't there be a period (".") after the month? If so it's weird that the test passes as is (IMO it would be worth tightening).
Suggested change
| assert.dom().hasText('Jan 28, 2022'); | |
| assert.dom().hasText('Jan. 28, 2022'); |
Contributor
Author
There was a problem hiding this comment.
The screenshot is not up-to-date, I will update it when possible. Thanks for letting me know :)
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-work
and removed
reviewed/ready-to-merge
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed date format in date cell renderer.
Related to : #dra-2915
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes