Skip to content

fix(keploy-framework): Replace type ignore with proper __aexit__ annotations #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

fix(keploy-framework): Replace type ignore with proper __aexit__ annotations #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb6d31
Initial plan
Copilot Nov 13, 2025
198a035
fix(keploy-framework): add proper type annotations to __aexit__ method
Copilot Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/keploy-framework/src/keploy_framework/recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
"""Recording session utilities."""

import httpx
from collections.abc import AsyncIterator
from contextlib import asynccontextmanager
from typing import AsyncIterator
from types import TracebackType

import httpx


class RecordingSession:
Expand All @@ -26,7 +28,12 @@ async def __aenter__(self) -> "RecordingSession":
self.client = httpx.AsyncClient(base_url=self.api_url)
return self

async def __aexit__(self, exc_type, exc_val, exc_tb) -> None: # type: ignore[no-untyped-def]
async def __aexit__(
self,
exc_type: type[BaseException] | None,
exc_val: BaseException | None,
exc_tb: TracebackType | None,
) -> None:
"""Exit recording context."""
if self.client:
await self.client.aclose()
Expand Down
Loading