fix(keploy-framework): Replace type ignore with proper __aexit__ annotations - #90
Closed
theinterneti with Copilot wants to merge 2 commits into
Closed
theinterneti with Copilot wants to merge 2 commits into
theinterneti with Copilot wants to merge 2 commits into
Conversation
- Import TracebackType from types module - Replace type: ignore comment with explicit type annotations - Fix import ordering per ruff requirements - Use collections.abc.AsyncIterator instead of typing.AsyncIterator Co-authored-by: theinterneti <169108167+theinterneti@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update phase 1 workflow enhancements based on review feedback
fix(keploy-framework): Replace type ignore with proper __aexit__ annotations
Nov 13, 2025
Owner
|
Closing this PR as it contains no changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback to add proper type annotations instead of suppressing type checking on the
__aexit__method.Changes
TracebackTypefromtypesmodule__aexit__parameters:exc_type: type[BaseException] | Noneexc_val: BaseException | Noneexc_tb: TracebackType | None# type: ignore[no-untyped-def]suppressioncollections.abc.AsyncIterator)Before
After
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.