feat: SW-2592 differentiate the assistant panel in AssistantLayout - #216
Open
boramyi-ts wants to merge 1 commit into
Open
feat: SW-2592 differentiate the assistant panel in AssistantLayout#216boramyi-ts wants to merge 1 commit into
boramyi-ts wants to merge 1 commit into
Conversation
Both AssistantLayout panels used the same bg-card card, so the assistant panel was indistinguishable from the content panel. Add an optional accent header cap (assistantTitle + icon/actions + close) rendered above the assistant slot — the content panel never gets one, so the two read as distinct. Backward compatible: no title → no cap, existing behavior. - New props: assistantTitle, assistantIcon, assistantHeaderActions, showAssistantClose. Close hides the panel via the provider's setVisible. - Story: MockAssistant drops its own header (now the cap) and puts the composer in a muted tray; a play assertion verifies the cap's background differs from the content and that close hides the panel. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SW-2592 — differentiate the assistant panel (AI agent layout manager)
AssistantLayoutrendered the assistant panel and the content panel with the samebg-cardcard, so the assistant was indistinguishable from the content next to it.Unlike
DataAppShellRightPanel, the panels here are already raised (bg-card) — so this isn't the "panel = body background" bug. The fix is differentiation, and since consumers pass a self-contained assistant (its own messages + composer), the layout manager now owns an optional accent header cap.API
assistantTitle(+assistantIcon,assistantHeaderActions,showAssistantClose). WhenassistantTitleis set, abg-accentheader band renders above theassistantslot; its close button hides the panel via the provider.AssistantDockControls, untouched).Before → After
Before, the assistant panel is the same card as the content with only its own plain header. After, an accent header cap brands it and sets it apart; the composer sits in a muted tray.
Bottom dock (after):
Testing
yarn typecheck✓ ·yarn lint✓ (0 warnings) · Storybook play 4/4, incl. a new assertion in Docked Right: the cap's background ≠ the content panel's, and close hides the panel.🤖 Generated with Claude Code