feat: SW-2592 raised surface for DataAppShellRightPanel - #217
Open
boramyi-ts wants to merge 1 commit into
Open
Conversation
The docked panel painted bg-background — the same token as <body> — so it
read as a column of the page rather than a surface on it. Give it (and the
overlay Sheet) a bg-card surface with a tinted accent header cap via a new
`surface` prop ("raised" default | "flat").
bg-card maps to --surface-bright in both themes, so it stays raised in dark
where bg-sidebar (which resolves to --surface = the body colour in dark)
would not. Surface only — no docking changes.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
owilliams-tetrascience
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SW-2592 — AI Agent panel missing background color
The docked
DataAppShellRightPanelpaintedbg-background— the same token as<body>— so it read as a column of the page rather than a surface on it. The only separation wasborder-l.Fix
Give the docked panel and the overlay
Sheeta raisedbg-cardsurface with a tinted accent header cap, via a newsurfaceprop ("raised"default |"flat").Why
bg-card, not the ticket'sbg-sidebar--sidebaris defined in dark, but maps to--surface— the same value as--backgroundin dark — sobg-sidebarwould reproduce the bug in dark (and disturb the nav).bg-card=--surface-brightis genuinely raised in both themes.bg-background(before)#FAFBFC#1C1B21bg-sidebar(ticket idea)#FFFFFF#1C1B21bg-card(this PR)#FFFFFF#313036Before → After
Light — before the panel is the same colour as the content ground; after it's a raised card with an accent header cap.
Dark
Scope
sidechanges (left/bottom docking was explicitly out of scope for DataAppShell).AssistantLayoutPR (feat: SW-2592 differentiate the assistant panel in AssistantLayout #216) so the two panel systems agree.ai/suggestion+ai/prompt-inputneed no change — they're transparent and now inherit the raised surface, so apps can drop theirbg-cardcompensation.Testing
yarn typecheck✓ ·yarn lint✓ (0 warnings) · Storybook play 4/4, incl. a surface assertion in With Right Panel: panel bg ≠ page ground, and header cap ≠ panel body.🤖 Generated with Claude Code