Skip to content

auth: widen constant-time login test margin #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
espadonne merged 1 commit into from
Sep 3, 2026
Merged

auth: widen constant-time login test margin #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion internal/web/handlers/auth/auth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,16 @@ func TestLogin_ConstantTime(t *testing.T) {

existing := measure("dave")
missing := measure("does-not-exist")
if missing < hashCost/2 {
// A shortcut that skips hashing makes the missing-user request
// ~1 ms. Compare against the cheaper of the two reference costs
// (a bare hash, or a full existing-user login which includes one)
// with a wide margin, because on a loaded CI runner either
// reference can be inflated several-fold by neighbouring tests.
ref := hashCost
if existing < ref {
ref = existing
}
if missing < ref/4 {
t.Fatalf("missing-user login skipped the hash: missing=%v hash=%v existing=%v", missing, hashCost, existing)
}
// Still reject an egregious divergence in either direction; the
Expand Down
Loading