auth: widen constant-time login test margin - #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestLogin_ConstantTimefailed again on an unrelated docs PR (#427): the in-test hash baseline measured 34 ms while a full existing-user login measured 22 ms and the missing-user login 13 ms, i.e. the baseline itself was inflated by neighbouring parallel tests on the shared runner. The assertion now compares the missing-user median against the cheaper of (hash cost, existing-user login) with a 4x margin. A real shortcut (~1 ms) still fails it.Test targets:
internal/web/handlers/authgreen