Reconstruct five scene profile pairs - #2138
Merged
Merged
Conversation
✅ PR validation — PassedCommitted merge introduces no reconstruction or attribution regression. Full merge validation
Byte-verified means the range carries Warnings: 1 linkcheck result(s) have unresolved relocations. Per-file link-check detailAll 34 changed file(s) compile to the ROM byte-for-byte with correct relocation targets.
The private worker commits a test merge, builds the stock ROM profile, compares every executable module, measures matched and source-built code, checks contributor lineage, and verifies affected relocations. The mod profile is opt-in and is not part of this merge gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2137. Reconstructs the registry-facing factory/profile pairs for BOOT, DSMT, TITLE, STAGE, and STAR_SELECT as lineage-supported source-style names: dScBoot_c_classInit / g_profile_BOOT; dScDSMT_c_classInit / g_profile_DSMT; dScTitle_c_classInit / g_profile_TITLE; dScStage_c_classInit / g_profile_STAGE; dScStarSel_c_classInit / g_profile_STAR_SELECT. The STAGE factory deliberately retains the project's Stage implementation type; this PR reconstructs registry symbols, not the underlying class representation. Exact original SM64DS spellings are not claimed. No source-owned profile descriptor data is invented. Validation: all five factories match 2004/b56 with strict relocation checks; 34 affected sources checked (33 VERIFIED, one pre-existing non-blocking BLIND-2 warning); five history-preserving path moves with attribution intact; 98/98 reconstructed TUs compile; 11,088/11,088 source functions and 4/4 source data claims reproduce; 106/106 modules exact; repository reference, attribution, compatibility, language-mode, and dead-reference gates pass.