Skip to content

Reconstruct five actor profile pairs - #2139

Merged
andrewboudreau merged 3 commits into
mainfrom
cpp/profile-reconstruction-wave9
Sep 2, 2026
Merged

Reconstruct five actor profile pairs#2139
andrewboudreau merged 3 commits into
mainfrom
cpp/profile-reconstruction-wave9

Conversation

@andrewboudreau

Copy link
Copy Markdown
Collaborator

Stacked on #2138. Reconstructs the registry-facing factory/profile pairs for GAME_OVER, YOSHI_EGG, BC_SWITCH, TREASURE_BOX, and ICE_BLOCK_LL: dScGameOver_c_classInit / g_profile_GAME_OVER; daYegg_c_classInit / g_profile_YOSHI_EGG; daObjBC_Switch_c_classInit / g_profile_BC_SWITCH; daObjTbox_c_classInit / g_profile_TREASURE_BOX; daObjIceBlock_c_classInit / g_profile_ICE_BLOCK_LL. The latter four deliberately preserve the separation between ROM RTTI class identity and existing community implementation aliases. Exact original SM64DS spellings are not claimed, and no source-owned profile descriptor data is invented. Validation: all five factories match 2004/b56 with strict relocation checks; all 18 affected sources are VERIFIED; the BlueCoinSwitch shadow TU passes 9/9 with clean relocation isolation; five history-preserving path moves keep attribution intact; 98/98 reconstructed TUs compile; 11,088/11,088 source functions and 4/4 source data claims reproduce; 106/106 modules exact; repository reference, attribution, compatibility, language-mode, and dead-reference gates pass.

@tangos-validator

tangos-validator Bot commented Sep 1, 2026

Copy link
Copy Markdown

✅ PR validation — Passed

Committed merge introduces no reconstruction or attribution regression.

Full merge validation

Check Result
Committed test merge yes
Byte-verified functions 10,765 / 11,347 (94.87%, +0)
Byte-verified code bytes 2,002,192 / 2,211,124 (90.55%, +0)
Claimed, not byte-verified 452 functions, 103,488 bytes (+0)
Perfect source moves 0 R100
Enrolled ranges (delinks complete) 11,059 functions, 2,053,148 bytes (92.86%, +0) -- differs from byte-verified by +294
Contributor credit 0 added, 0 changed, 0 lost
Relocation check 18 checked; 18 VERIFIED
Port reference check 405 checked; 0 stale
Module fidelity 106/106 exact; 100.000000% compared bytes
Code linked from verified source 11,088 functions, 2,067,148 bytes (93.49%)
Module bytes from source 2,067,148 / 3,049,600 (67.8%); 811,492 (26.6%) are data no delink entry reaches
ROM data reproduced from source 564 symbol(s) exact, 161 partial, 5 differ

Byte-verified means the range carries complete in a delinks.txt, so the ROM build compiled it and compared it to the cartridge. The 452 claimed functions have a src/ file named after the symbol with no NONMATCHING banner, and nothing compiles them -- dsd fills their addresses with the ROM's own bytes. Both together are the 11,217 this project calls matched.

Per-file link-check detail

All 18 changed file(s) compile to the ROM byte-for-byte with correct relocation targets.

File Symbol Result Slots checked
src/_ZN13dScGameOver_c13InitResourcesEv.cpp _ZN13dScGameOver_c13InitResourcesEv ✅ verified 1
src/_ZN13dScGameOver_c16CleanupResourcesEv.cpp _ZN13dScGameOver_c16CleanupResourcesEv ✅ verified 1
src/_ZN13dScGameOver_c16OnPendingDestroyEv.cpp _ZN13dScGameOver_c16OnPendingDestroyEv ✅ verified 1
src/_ZN13dScGameOver_c6RenderEv.cpp _ZN13dScGameOver_c6RenderEv ✅ verified 1
src/_ZN13dScGameOver_c8BehaviorEv.cpp _ZN13dScGameOver_c8BehaviorEv ✅ verified 1
src/_ZN13dScGameOver_cD0Ev.cpp _ZN13dScGameOver_cD0Ev ✅ verified 1
src/_ZN13dScGameOver_cD1Ev.cpp _ZN13dScGameOver_cD1Ev ✅ verified 1
src/_ZN8YoshiEgg13InitResourcesEv.cpp _ZN8YoshiEgg13InitResourcesEv ✅ verified 1
src/_ZN8YoshiEgg16CleanupResourcesEv.cpp _ZN8YoshiEgg16CleanupResourcesEv ✅ verified 1
src/_ZN8YoshiEgg6RenderEv.cpp _ZN8YoshiEgg6RenderEv ✅ verified 1
src/_ZN8YoshiEgg8BehaviorEv.cpp _ZN8YoshiEgg8BehaviorEv ✅ verified 1
src/_ZN8YoshiEggD0Ev.cpp _ZN8YoshiEggD0Ev ✅ verified 1
src/_ZN8YoshiEggD1Ev.cpp _ZN8YoshiEggD1Ev ✅ verified 1
src/dScGameOver_c_classInit.cpp dScGameOver_c_classInit ✅ verified 1
src/daObjBC_Switch_c_classInit.c daObjBC_Switch_c_classInit ✅ verified 1
src/daObjIceBlock_c_classInit.c daObjIceBlock_c_classInit ✅ verified 1
src/daObjTbox_c_classInit.c daObjTbox_c_classInit ✅ verified 1
src/daYegg_c_classInit.c daYegg_c_classInit ✅ verified 1

The private worker commits a test merge, builds the stock ROM profile, compares every executable module, measures matched and source-built code, checks contributor lineage, and verifies affected relocations. The mod profile is opt-in and is not part of this merge gate.

@andrewboudreau
andrewboudreau marked this pull request as ready for review September 2, 2026 04:50
Base automatically changed from cpp/profile-reconstruction-wave8 to main September 2, 2026 06:11
@andrewboudreau
andrewboudreau merged commit 648804b into main Sep 2, 2026
9 checks passed
@andrewboudreau
andrewboudreau deleted the cpp/profile-reconstruction-wave9 branch September 2, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant