Skip to content

fix: carry the tracing span in the request store instead of copying the event - #16600

Open
Nic-Polumeyv wants to merge 4 commits into
sveltejs:version-3from
Nic-Polumeyv:single-event-identity
Open

fix: carry the tracing span in the request store instead of copying the event#16600
Nic-Polumeyv wants to merge 4 commits into
sveltejs:version-3from
Nic-Polumeyv:single-event-identity

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Fixes #15040. Every server-side copy of the request event existed only to vary tracing.current per span. It's now a getter reading getActiveSpan(), the shape floated in #13899 (comment), and the copies are gone. Inside a user-created span, current returns that span rather than the enclosing SvelteKit one.

The data-request copy is gone too; the pathname is now normalized in place instead.

Part of #16519.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 31, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 080c26a:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/080c26a596f20712fd874b26cf03874a3884dc5f

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16600

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 080c26a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Nic-Polumeyv
Nic-Polumeyv force-pushed the single-event-identity branch from f5e6545 to ba9fc1d Compare August 1, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handleFetch hook receive empty event object after 2.31.0 sveltekit upgrade

1 participant