Skip to content

chore: extract record_traced_span for the span + request-store ceremony - #16599

Closed
Nic-Polumeyv wants to merge 4 commits into
sveltejs:version-3from
Nic-Polumeyv:record-traced-span
Closed

chore: extract record_traced_span for the span + request-store ceremony#16599
Nic-Polumeyv wants to merge 4 commits into
sveltejs:version-3from
Nic-Polumeyv:record-traced-span

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Form actions, both load paths, remote calls and remote form posts each hand-build the same wrapper: open a span, merge_tracing the event, re-enter the request store, run the work. This extracts it into record_traced_span next to record_span and rewrites those five sites.

The two remote-functions.js hunks overlap with #16064, which restructures that file. Happy to rebase whichever lands second.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 31, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 424b6ab:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/424b6ab420a36060e1436358140a7b42544e0cd0

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16599

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 424b6ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor Author

Superseded by #16600, which removes these call sites instead of extracting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant