chore: extract record_traced_span for the span + request-store ceremony - #16599
chore: extract record_traced_span for the span + request-store ceremony#16599Nic-Polumeyv wants to merge 4 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/424b6ab420a36060e1436358140a7b42544e0cd0Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
|
|
Superseded by #16600, which removes these call sites instead of extracting them. |
Form actions, both
loadpaths, remote calls and remote form posts each hand-build the same wrapper: open a span,merge_tracingthe event, re-enter the request store, run the work. This extracts it intorecord_traced_spannext torecord_spanand rewrites those five sites.The two
remote-functions.jshunks overlap with #16064, which restructures that file. Happy to rebase whichever lands second.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits