Skip to content

refactor(cli): cover functions serve-main-bundler with effect lint (CLI-2592) #6971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7ttp wants to merge 1 commit into from
+569 −431
Open

refactor(cli): cover functions serve-main-bundler with effect lint (CLI-2592) #6971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .oxlintrc.effect.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
"!apps/cli/src/shared/functions/functions-docker.unit.test.ts",
"!apps/cli/src/shared/functions/functions.shared.ts",
"!apps/cli/src/shared/functions/functions.shared.unit.test.ts",
"!apps/cli/src/shared/functions/serve-main-bundler.integration.test.ts",
"!apps/cli/src/shared/functions/serve-main-bundler.ts",
"!apps/cli/src/shared/functions/serve-main-bundler.unit.test.ts",
"!apps/cli/src/shared/functions/serve.ts",
"!apps/cli/src/shared/functions/serve.unit.test.ts",
"!apps/cli/src/shared/git/**",
Expand Down
5 changes: 4 additions & 1 deletion apps/cli/scripts/build-binary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { Effect } from "effect";
import { bundleServeMainTemplate } from "../src/shared/functions/serve-main-bundler.ts";
import { compileOptions, stackReleaseDefine } from "./compile-options.ts";

Expand All @@ -23,7 +24,9 @@ const result = await Bun.build({
define: {
SUPABASE_CLI_VERSION: JSON.stringify(packageJson.version),
...(await stackReleaseDefine()),
SUPABASE_FUNCTIONS_SERVE_MAIN_TEMPLATE: JSON.stringify(await bundleServeMainTemplate()),
SUPABASE_FUNCTIONS_SERVE_MAIN_TEMPLATE: JSON.stringify(
await Effect.runPromise(bundleServeMainTemplate()),
),
// Skips msgpackr's native addon probe at the build host's path, which can hang macOS startup.
"process.env.MSGPACKR_NATIVE_ACCELERATION_DISABLED": JSON.stringify("true"),
},
Expand Down
5 changes: 4 additions & 1 deletion apps/cli/scripts/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { copyFile, mkdir, readFile, rm, writeFile } from "node:fs/promises";
import path from "node:path";
import process from "node:process";
import { parseArgs } from "node:util";
import { Effect } from "effect";
import { bundleServeMainTemplate } from "../src/shared/functions/serve-main-bundler.ts";
import { compileOptions, stackReleaseDefine } from "./compile-options.ts";
import { darwinBinaries, MACOS_IDENTIFIERS } from "./macos-signing.ts";
Expand Down Expand Up @@ -89,7 +90,9 @@ const distDir = path.join(root, "dist");
const goSource = path.resolve(root, "apps/cli-go");
const buildDefines = {
...(await stackReleaseDefine()),
SUPABASE_FUNCTIONS_SERVE_MAIN_TEMPLATE: JSON.stringify(await bundleServeMainTemplate()),
SUPABASE_FUNCTIONS_SERVE_MAIN_TEMPLATE: JSON.stringify(
await Effect.runPromise(bundleServeMainTemplate()),
),
SUPABASE_CLI_POSTHOG_KEY: JSON.stringify(process.env.POSTHOG_API_KEY ?? ""),
SUPABASE_CLI_POSTHOG_HOST: JSON.stringify(process.env.POSTHOG_ENDPOINT ?? ""),
// Skips msgpackr's startup probe for its native addon at the build host's store path, which
Expand Down
Loading
Loading