refactor(cli): cover functions serve-main-bundler with effect lint (CLI-2592) - #6971
Open
7ttp wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed and reported zero findings. Reading the changed code, surrounding runtime code, callers, tests, and trusted conventions revealed no additional actionable issues. Tests were not run because dependencies are not installed.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
brings the serve main bundler and its tests under the effect lint
whats introduced?
serve-main-bundler.tsand its unit and integration tests join the allow listbundleServeMainTemplatenow returns an effect, whichserve.tsyields and the build scripts and offline e2e run withEffect.runPromiseserve.tsjoins, so an interrupted startup still fills the template cache, and an esbuild failure stays a defectDeferredand scoped abort signals instead of manual promises, with the fakeDeno.errorsclasses asData.Errorref