Skip to content

refactor(cli): cover functions serve-main-bundler with effect lint (CLI-2592) - #6971

Open
7ttp wants to merge 1 commit into
7ttp/cli-2592-functions-area-coverage-deploy-testsfrom
7ttp/cli-2592-functions-area-coverage-serve-main
Open

7ttp wants to merge 1 commit into
7ttp/cli-2592-functions-area-coverage-deploy-testsfrom
7ttp/cli-2592-functions-area-coverage-serve-main

Conversation

@7ttp

@7ttp 7ttp commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

TL;DR

brings the serve main bundler and its tests under the effect lint

whats introduced?

  • serve-main-bundler.ts and its unit and integration tests join the allow list
  • bundleServeMainTemplate now returns an effect, which serve.ts yields and the build scripts and offline e2e run with Effect.runPromise
  • the template bundles in a detached fiber that serve.ts joins, so an interrupted startup still fills the template cache, and an esbuild failure stays a defect
  • the bundler integration tests keep all eighteen cases and coordinate through Deferred and scoped abort signals instead of manual promises, with the fake Deno.errors classes as Data.Error

ref

@7ttp 7ttp self-assigned this Oct 2, 2026
@7ttp
7ttp added this pull request to stack #6969 October 2, 2026 21:26
@7ttp
7ttp requested a review from a team as a code owner October 2, 2026 21:26

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed and reported zero findings. Reading the changed code, surrounding runtime code, callers, tests, and trusted conventions revealed no additional actionable issues. Tests were not run because dependencies are not installed.

Findings

No issues found.

Stats

Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant