Remove dead code: Postman wrapper, IFunctionStore.SetResult, Result static class

Core/Cleipnir.ResilientFunctions.Tests/InMemoryTests/StoreTests.cs

@@ -269,16 +269,4 @@ public override Task GetResultsReturnsEmptyDictionaryForEmptyInput()
     [TestMethod]
     public override Task GetResultsReturnsOnlyExistingFunctionResults()
         => GetResultsReturnsOnlyExistingFunctionResults(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultSucceedsWhenOwnerMatches()
-        => SetResultSucceedsWhenOwnerMatches(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenOwnerDoesNotMatch()
-        => SetResultDoesNothingWhenOwnerDoesNotMatch(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenFunctionDoesNotExist()
-        => SetResultDoesNothingWhenFunctionDoesNotExist(FunctionStoreFactory.Create());
 }

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/StoreTests.cs

@@ -2357,72 +2357,4 @@ await store.SucceedFunction(
         results.ContainsKey(nonExistentFunctionId).ShouldBeFalse();
     }
 
-    public abstract Task SetResultSucceedsWhenOwnerMatches();
-    protected async Task SetResultSucceedsWhenOwnerMatches(Task<IFunctionStore> storeTask)
-    {
-        var store = await storeTask;
-        var functionId = TestStoredId.Create();
-        var owner = ReplicaId.NewId();
-        var result = "test result".ToJson().ToUtf8Bytes();
-
-        // Create function with owner
-        await store.CreateFunction(
-            functionId,
-            "humanInstanceId",
-            param: Test.SimpleStoredParameter,
-            leaseExpiration: DateTime.UtcNow.Ticks,
-            postponeUntil: null,
-            timestamp: DateTime.UtcNow.Ticks,
-            parent: null,
-            owner: owner
-        ).ShouldNotBeNullAsync();
-
-        // Set result
-        await store.SetResult(functionId, result, owner);
-
-        // Verify result was set
-        var results = await store.GetResults([functionId]);
-        results[functionId].ShouldBe(result);
-    }
-
-    public abstract Task SetResultDoesNothingWhenOwnerDoesNotMatch();
-    protected async Task SetResultDoesNothingWhenOwnerDoesNotMatch(Task<IFunctionStore> storeTask)
-    {
-        var store = await storeTask;
-        var functionId = TestStoredId.Create();
-        var owner = ReplicaId.NewId();
-        var wrongOwner = ReplicaId.NewId();
-        var result = "test result".ToJson().ToUtf8Bytes();
-
-        // Create function with owner
-        await store.CreateFunction(
-            functionId,
-            "humanInstanceId",
-            param: Test.SimpleStoredParameter,
-            leaseExpiration: DateTime.UtcNow.Ticks,
-            postponeUntil: null,
-            timestamp: DateTime.UtcNow.Ticks,
-            parent: null,
-            owner: owner
-        ).ShouldNotBeNullAsync();
-
-        // Try to set result with wrong owner
-        await store.SetResult(functionId, result, wrongOwner);
-
-        // Verify result was not set
-        var results = await store.GetResults([functionId]);
-        results[functionId].ShouldBeNull();
-    }
-
-    public abstract Task SetResultDoesNothingWhenFunctionDoesNotExist();
-    protected async Task SetResultDoesNothingWhenFunctionDoesNotExist(Task<IFunctionStore> storeTask)
-    {
-        var store = await storeTask;
-        var nonExistentFunctionId = TestStoredId.Create();
-        var owner = ReplicaId.NewId();
-        var result = "test result".ToJson().ToUtf8Bytes();
-
-        // Try to set result for non-existent function (should not throw)
-        await store.SetResult(nonExistentFunctionId, result, owner);
-    }
 }

Core/Cleipnir.ResilientFunctions.Tests/TestTemplates/WatchDogsTests/CrashableFunctionStore.cs

@@ -215,11 +215,6 @@ public Task<bool> DeleteFunction(StoredId storedId)
             ? Task.FromException<IReadOnlyDictionary<StoredId, byte[]?>>(new TimeoutException())
             : _inner.GetResults(storedIds);
 
-    public Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-        => _crashed
-            ? Task.FromException(new TimeoutException())
-            : _inner.SetResult(storedId, result, expectedReplica);
-
     public IFunctionStore WithPrefix(string prefix) => _inner.WithPrefix(prefix);
 }
 

Core/Cleipnir.ResilientFunctions/ActionRegistration.cs

@@ -26,9 +26,8 @@ public ActionRegistration(
         Invoker<TParam, Unit> invoker,
         ControlPanelFactory<TParam> controlPanelFactory,
         MessageWriters messageWriters,
-        Postman postman,
         UtcNow utcNow
-    ) : base(storedType, postman, functionStore, utcNow)
+    ) : base(storedType, functionStore, utcNow)
     {
         Type = flowType;
         _invoker = invoker;
@@ -59,8 +58,8 @@ public async Task SendMessage<T>(
         FlowInstance flowInstance,
         T message,
         string? idempotencyKey = null
-    ) where T : class => await Postman.SendMessage(StoredId.Create(StoredType, flowInstance.Value), message, idempotencyKey);
+    ) where T : class => await MessageWriters.For(flowInstance).AppendMessage(message, idempotencyKey);
 
     public async Task SendMessages(IReadOnlyList<BatchedMessage> messages)
-        => await Postman.SendMessages(messages);
+        => await MessageWriters.AppendMessages(messages);
 }

Core/Cleipnir.ResilientFunctions/BaseRegistration.cs

@@ -3,25 +3,22 @@
 using System.Threading.Tasks;
 using Cleipnir.ResilientFunctions.CoreRuntime;
 using Cleipnir.ResilientFunctions.Domain;
-using Cleipnir.ResilientFunctions.Messaging;
 using Cleipnir.ResilientFunctions.Storage;
 
 namespace Cleipnir.ResilientFunctions;
 
 public abstract class BaseRegistration
 {
     private readonly IFunctionStore _functionStore;
-    protected Postman Postman { get; } 
     public StoredType StoredType { get; }
     protected UtcNow UtcNow { get; }
 
-    protected BaseRegistration(StoredType storedType, Postman postman, IFunctionStore functionStore, UtcNow utcNow)
+    protected BaseRegistration(StoredType storedType, IFunctionStore functionStore, UtcNow utcNow)
     {
         _functionStore = functionStore;
         StoredType = storedType;
-        Postman = postman;
         UtcNow = utcNow;
-    } 
+    }
 
     public StoredId MapToStoredId(FlowInstance instance) => StoredId.Create(StoredType, instance.Value);
 

Core/Cleipnir.ResilientFunctions/Domain/Result.cs

@@ -4,12 +4,6 @@
 
 namespace Cleipnir.ResilientFunctions.Domain;
 
-public static class Result
-{
-    public static Result<T> SucceedWithValue<T>(T value) => new(value);
-    public static Result<Unit> SucceedWithUnit { get; } = new Result<Unit>(Unit.Instance);
-}
-
 public static class Succeed
 {
     public static Result<T> WithValue<T>(T value) => new Result<T>(value);

Core/Cleipnir.ResilientFunctions/FuncRegistration.cs

@@ -25,9 +25,8 @@ public FuncRegistration(
         Invoker<TParam, TReturn> invoker,
         ControlPanelFactory<TParam, TReturn> controlPanelFactory,
         MessageWriters messageWriters,
-        Postman postman,
         UtcNow utcNow
-    ) : base(storedType, postman, functionStore, utcNow)
+    ) : base(storedType, functionStore, utcNow)
     {
         Type = flowType;
         _invoker = invoker;
@@ -59,8 +58,8 @@ public async Task SendMessage<T>(
         FlowInstance flowInstance,
         T message,
         string? idempotencyKey = null
-    ) where T : class => await Postman.SendMessage(StoredId.Create(StoredType, flowInstance.Value), message, idempotencyKey);
+    ) where T : class => await MessageWriters.For(flowInstance).AppendMessage(message, idempotencyKey);
 
     public async Task SendMessages(IReadOnlyList<BatchedMessage> messages)
-        => await Postman.SendMessages(messages);
+        => await MessageWriters.AppendMessages(messages);
 }

Core/Cleipnir.ResilientFunctions/FunctionsRegistry.cs

@@ -258,16 +258,13 @@ public FuncRegistration<TParam, TReturn> RegisterFunc<TParam, TReturn>(
                 serializer
             );
 
-            var postman = new Postman(messageWriters);
-
             var registration = new FuncRegistration<TParam, TReturn>(
                 flowType,
                 storedType,
                 _functionStore,
                 invoker,
                 controlPanels,
                 messageWriters,
-                postman,
                 _settings.UtcNow
             );
             _functions[flowType] = registration;
@@ -343,16 +340,13 @@ private ParamlessRegistration RegisterParamless(
                 serializer
             );
 
-            var postman = new Postman(messageWriters);
-
             var registration = new ParamlessRegistration(
                 flowType,
                 storedType,
                 _functionStore,
                 invoker,
                 controlPanels,
                 messageWriters,
-                postman,
                 _settings.UtcNow
             );
             _functions[flowType] = registration;
@@ -427,16 +421,13 @@ public ActionRegistration<TParam> RegisterAction<TParam>(
                 _functionStore,
                 serializer
             );
-            var postman = new Postman(messageWriters);
-
             var registration = new ActionRegistration<TParam>(
                 flowType,
                 storedType,
                 _functionStore,
                 rActionInvoker,
                 controlPanels,
                 messageWriters,
-                postman,
                 _settings.UtcNow
             );
             _functions[flowType] = registration;

Core/Cleipnir.ResilientFunctions/Messaging/MessageAndIdempotencyKey.cs

@@ -1,9 +1,3 @@
-namespace Cleipnir.ResilientFunctions.Messaging;
+namespace Cleipnir.ResilientFunctions.Messaging;
 
-public record MessageAndIdempotencyKey(object Message, string? IdempotencyKey = null);
-
-public static class MessageAndIdempotencyKeyExtensions 
-{
-    public static MessageAndIdempotencyKey ToMessageAndIdempotencyKey(this object message, string? idempotencyKey = null) 
-        => new(message, idempotencyKey);
-}
+public record MessageAndIdempotencyKey(object Message, string? IdempotencyKey = null);

Core/Cleipnir.ResilientFunctions/ParamlessRegistration.cs

@@ -27,9 +27,8 @@ public ParamlessRegistration(
         Invoker<Unit, Unit> invoker,
         ControlPanelFactory controlPanelFactory,
         MessageWriters messageWriters,
-        Postman postman,
         UtcNow utcNow
-    ) : base(storedType, postman, functionStore, utcNow)
+    ) : base(storedType, functionStore, utcNow)
     {
         Type = flowType;
         _invoker = invoker;
@@ -70,9 +69,9 @@ public async Task SendMessage<T>(
                 await Schedule(flowInstance);
         }
 
-        await Postman.SendMessage(StoredId.Create(StoredType, flowInstance.Value), message, idempotencyKey);
+        await MessageWriters.For(flowInstance).AppendMessage(message, idempotencyKey);
     }
 
     public async Task SendMessages(IReadOnlyList<BatchedMessage> messages)
-        => await Postman.SendMessages(messages);
+        => await MessageWriters.AppendMessages(messages);
 }

Core/Cleipnir.ResilientFunctions/Storage/IFunctionStore.cs

@@ -110,5 +110,4 @@ Task<bool> SuspendFunction(
 
     IFunctionStore WithPrefix(string prefix);
     Task<IReadOnlyDictionary<StoredId, byte[]?>> GetResults(IEnumerable<StoredId> storedIds);
-    Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica);
 }

Core/Cleipnir.ResilientFunctions/Storage/InMemoryFunctionStore.cs

@@ -563,22 +563,6 @@ public virtual Task<bool> DeleteFunction(StoredId storedId)
         }
     }
 
-    public Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-    {
-        lock (_sync)
-        {
-            if (!_states.ContainsKey(storedId))
-                return Task.CompletedTask;
-
-            var state = _states[storedId];
-            if (state.Owner != expectedReplica)
-                return Task.CompletedTask;
-
-            state.Result = result;
-            return Task.CompletedTask;
-        }
-    }
-
     private class InnerState
     {
         public StoredId StoredId { get; init; } = null!;

Samples/Sample.ConsoleApp/Utils/CrashableFunctionStore.cs

@@ -196,11 +196,6 @@ public Task<bool> DeleteFunction(StoredId storedId)
             ? Task.FromException<IReadOnlyDictionary<StoredId, byte[]?>>(new TimeoutException())
             : _inner.GetResults(storedIds);
 
-    public Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-        => _crashed
-            ? Task.FromException(new TimeoutException())
-            : _inner.SetResult(storedId, result, expectedReplica);
-
     public IFunctionStore WithPrefix(string prefix)
         => _inner.WithPrefix(prefix);
 }

Stores/MariaDB/Cleipnir.ResilientFunctions.MariaDB.Tests/StoreTests.cs

@@ -258,16 +258,4 @@ public override Task GetResultsReturnsEmptyDictionaryForEmptyInput()
     [TestMethod]
     public override Task GetResultsReturnsOnlyExistingFunctionResults()
         => GetResultsReturnsOnlyExistingFunctionResults(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultSucceedsWhenOwnerMatches()
-        => SetResultSucceedsWhenOwnerMatches(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenOwnerDoesNotMatch()
-        => SetResultDoesNothingWhenOwnerDoesNotMatch(FunctionStoreFactory.Create());
-
-    [TestMethod]
-    public override Task SetResultDoesNothingWhenFunctionDoesNotExist()
-        => SetResultDoesNothingWhenFunctionDoesNotExist(FunctionStoreFactory.Create());
 }

Stores/MariaDB/Cleipnir.ResilientFunctions.MariaDB/MariaDbFunctionStore.cs

@@ -913,28 +913,6 @@ public IFunctionStore WithPrefix(string prefix)
         return results;
     }
 
-    private string? _setResultSql;
-    public async Task SetResult(StoredId storedId, byte[] result, ReplicaId expectedReplica)
-    {
-        await using var conn = await CreateOpenConnection(_connectionString);
-        _setResultSql ??= $@"
-            UPDATE {_tablePrefix}
-            SET result_json = ?
-            WHERE id = ? AND owner = ?";
-
-        await using var command = new MySqlCommand(_setResultSql, conn)
-        {
-            Parameters =
-            {
-                new() { Value = result },
-                new() { Value = storedId.AsGuid.ToString("N") },
-                new() { Value = expectedReplica.AsGuid.ToString("N") }
-            }
-        };
-
-        await command.ExecuteNonQueryAsync();
-    }
-
     private string? _deleteFunctionSql;
     private async Task<bool> DeleteStoredFunction(StoredId storedId)
     {