Remove dead code: Postman wrapper, IFunctionStore.SetResult, Result static class#140
Open
Remove dead code: Postman wrapper, IFunctionStore.SetResult, Result static class#140
Conversation
Postman was a two-method passthrough over MessageWriters with no behaviour of its own. Inline the calls in the registration classes and drop the type.
The static `Result` class exposed `SucceedWithValue<T>` and `SucceedWithUnit`, both shadowed by the parallel `Succeed` class that every callsite uses instead. The `ToMessageAndIdempotencyKey` extension had zero references.
`SetResult` was never called from production code; the only callers were the three `StoreTests` cases that exist to test the method itself. Drop the interface method, all four store implementations (InMemory + Postgres + SqlServer + MariaDB), the test wrappers in `CrashableFunctionStore`, and the abstract test methods plus their overrides in each store's test project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the recent dead-code cleanup. Three independent removals on this branch:
MessageWriterswith no behaviour of its own. Inlined the calls in the registration classes.IFunctionStore.SetResult— never called from production code; the only callers were the threeStoreTestscases that exist to test the method itself. Dropped from the interface, all four store implementations (InMemory + Postgres + SqlServer + MariaDB), theCrashableFunctionStoretest wrappers, and the test methods.public static class Result—Result.SucceedWithValue<T>andResult.SucceedWithUnitwere both shadowed by the parallelSucceed.WithValue/Succeed.WithUnitthat every callsite uses instead. Also dropped the unusedToMessageAndIdempotencyKeyextension.Verified against the Cleipnir.NET consumer repo — none of the removed APIs are referenced there.
Net: ~225 lines removed across 16 files.
Test plan
dotnet buildclean (0 warnings)