Skip to content

fix(reviews): surface failed approvals and clear stale bulk selection #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rassl merged 1 commit into from
Jul 24, 2026
Merged

fix(reviews): surface failed approvals and clear stale bulk selection #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/app/admin/reviews/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@ export default function ReviewsPage() {
)
}
await fetchReviews(skip, { silent: true })
// The silent refetch intentionally skips the selection reset, so clear the
// now-stale selection here — decided rows have left the pending list.
setSelectedIds(new Set())
refreshPendingCount()
}

Expand Down
6 changes: 6 additions & 0 deletions src/components/admin/review-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,13 @@ export function ReviewRow({
: undefined
const res = await approveReview(review.ref_id, override)
if (res.error_message || res.status === "failed") {
// Keep the row and its error visible instead of silently refetching it
// out of the pending list (it is now 'failed', not pending) — otherwise
// a failed merge just vanishes and looks like it succeeded. Still refresh
// the pending badge so the count reflects that it left the queue.
setInlineError(res.error_message ?? "Approval failed")
onCountRefresh?.()
return
}
onRefresh()
onCountRefresh?.()
Expand Down
Loading