fix(reviews): surface failed approvals and clear stale bulk selection#371
Merged
Conversation
Two UI guardrails paired with the backend merge-reconciliation fix: - review-row: on a failed/errored approval, keep the row and its inline error visible instead of immediately refetching it out of the pending list. A failed merge (e.g. "Nodes already merged") previously just vanished and looked like it had succeeded. Still refresh the pending badge so the count reflects that the item left the queue. - reviews page: clear selectedIds after a bulk approve/dismiss. The silent refetch intentionally skips the selection reset, which left stale ids selected after the decided rows had left the list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two UI guardrails paired with the backend merge-reconciliation fix:
review-row: on a failed/errored approval, keep the row and its inline error visible instead of immediately refetching it out of the pending list. A failed merge (e.g. "Nodes already merged") previously just vanished and looked like it had succeeded. Still refresh the pending badge so the count reflects that the item left the queue.
reviews page: clear selectedIds after a bulk approve/dismiss. The silent refetch intentionally skips the selection reset, which left stale ids selected after the decided rows had left the list.