Skip to content

build: upgrade SwiftFormat to 0.58.7 #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robmaceachern merged 1 commit into from
Sep 10, 2026
Merged

build: upgrade SwiftFormat to 0.58.7 #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tools]
tuist = "4.23.0"
swiftformat = "0.54.2"
swiftformat = "0.58.7"

[settings]
# do not try to read versions from .nvmrc, .ruby-version, etc.
Expand Down
4 changes: 4 additions & 0 deletions .swiftformat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,7 @@
--xcodeindentation disabled

--disable unusedArguments

# Preserve the existing rule set when upgrading from SwiftFormat 0.54.2.
# Adopting these newer default rules is a separate style decision.
--disable docCommentsBeforeModifiers,fileMacro,modifiersOnSameLine,preferCountWhere,redundantPublic,swiftTestingTestCaseNames
1 change: 0 additions & 1 deletion Samples/TicTacToe/Sources/Game/RunGameWorkflow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ extension RunGameWorkflow {
))

case .maybeQuit:

let takeTurnsScreen = TakeTurnsWorkflow(
playerX: state.playerX,
playerO: state.playerO
Expand Down
2 changes: 0 additions & 2 deletions Samples/TicTacToe/Tests/TakeTurnsWorkflowTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ class TakeTurnsWorkflowTests: XCTestCase {
TakeTurnsWorkflow(playerX: "X", playerO: "O")
.renderTester(initialState: emptyBoardState)
.render { screen in

// The display value for player X should match what was passed to the workflow.
XCTAssertEqual(screen.playerX, "X")

Expand Down Expand Up @@ -272,7 +271,6 @@ class TakeTurnsWorkflowTests: XCTestCase {
TakeTurnsWorkflow(playerX: "X", playerO: "O")
.renderTester(initialState: boardState)
.render { screen in

// The display value for player X should match what was passed to the workflow.
XCTAssertEqual(screen.playerX, "X")

Expand Down
1 change: 0 additions & 1 deletion Samples/Tutorial/Frameworks/Tutorial5Complete/Tests/RootWorkflowTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ class RootWorkflowTests: XCTestCase {
XCTFail("Expected a right bar button")

case .button(let button):

switch button.content {
case .text(let text):
XCTAssertEqual("Save", text)
Expand Down
2 changes: 1 addition & 1 deletion WorkflowUI/Sources/Observation/WorkflowUIObserver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import Foundation
/// **N.B. This is currently part of an experimental interface, and may have breaking changes in the future.**
@_spi(ExperimentalObservation)
public protocol WorkflowUIObserver {
func observeEvent<E: WorkflowUIEvent>(_ event: E)
func observeEvent(_ event: some WorkflowUIEvent)
}

// MARK: - Global Observation
Expand Down
1 change: 0 additions & 1 deletion WorkflowUI/Tests/UIViewControllerExtensionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ class UIViewControllerExtensionTests: XCTestCase {
let fixture = TestFixture(screen: Screen1(), environment: .empty)

show(vc: fixture.root) { root in

fixture.clearAllEvents()

// Update to the same screen type should do nothing.
Expand Down
Loading