Skip to content

build: upgrade SwiftFormat to 0.58.7 - #400

Merged
robmaceachern merged 1 commit into
mainfrom
codex/mrkt-142-swiftformat-0587
Sep 10, 2026
Merged

robmaceachern merged 1 commit into
mainfrom
codex/mrkt-142-swiftformat-0587

Conversation

@robmaceachern

@robmaceachern robmaceachern commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

Summary

Upgrade SwiftFormat from 0.54.2 to 0.58.7 to support Swift 6.2 raw identifiers, including human-readable Swift Testing function names.

Changes

  • Pin 0.58.7 in the existing mise configuration; local tooling and CI use the same version.
  • Explicitly disable the six default rules added since the previous formatter version, preserving the repository's enabled rule set. Adopting those rules remains a separate style decision.
  • Apply five small mechanical source cleanups required by existing rules: remove five blank lines and express one generic protocol requirement using the equivalent some WorkflowUIEvent parameter spelling.

Validation

  • mise exec -- swiftformat --version reports 0.58.7.
  • mise exec -- swiftformat --lint . --cache ignore: 0/283 files require formatting; 22 files skipped by formatter/configuration rules.
  • The old 0.54.2 formatter passed the unchanged main-source baseline. A standalone Swift Testing fixture with a backticked, space-containing function name fails its parser and passes lint under 0.58.7 with this repository's configuration.
  • git diff --check passes. Application, UI, and snapshot suites were not rerun locally; CI remains the build/test validation gate.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation (configuration comments explain preserved rule defaults)

This response was drafted with AI assistance.

Support Swift 6.2 raw identifiers with a pinned formatter and preserve existing formatting policy. Keep this MRKT-142 supporting tooling change independent of navigation API work.

---
*This response was drafted with AI assistance.*
@robmaceachern
robmaceachern marked this pull request as ready for review September 10, 2026 18:04
@robmaceachern
robmaceachern requested review from a team as code owners September 10, 2026 18:04
@robmaceachern
robmaceachern enabled auto-merge (squash) September 10, 2026 18:04
robmaceachern added a commit that referenced this pull request Sep 10, 2026
Keep the SwiftFormat upgrade independently reviewable in #400 while validating the MRKT-142 lifecycle API above that prerequisite.

---
*This response was drafted with AI assistance.*

* origin/codex/mrkt-142-swiftformat-0587:
  build: upgrade SwiftFormat to 0.58.7
@robmaceachern
robmaceachern merged commit 03786ed into main Sep 10, 2026
14 checks passed
@robmaceachern
robmaceachern deleted the codex/mrkt-142-swiftformat-0587 branch September 10, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants