Repository navigation
The error codes spin writes, held to spin's own list - #29
Merged
Merged
Conversation
spin v20261110.01, the release versions.yaml pins, writes key_not_enrolled (add_key, with the keys page as url) and no_extension_release, and no longer writes access_needs_signature, keyring_needs_signature or no_key_held (spin 22c480b66). The contract still had the old three, so key_not_enrolled was an envelope isErrorEnvelope refused and the extension showed as internal. The contract, the errors module and the fake spin now have spin's codes: key_not_enrolled takes no_key_held's Add Key, `spin ssh-key add` in a terminal, which has the passkey confirm the key; no_extension_release is shown whole, as no_vscode_server is. The keyring signing flow and its button go. hack/errcodes holds ACTION_OF to errorActions in spin's cmd/cli/cmd/errcode.go, code and action both ways; task contract:spin reads that file at the pinned release over git, and the Bump spin workflow runs it after the bump, with the read token, so a release that adds or drops a code fails the bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aledbf
added a commit
that referenced
this pull request
Nov 12, 2026
#27 and #29 merged from the same base, so main ran #27's tests against #29's contract: connect.test failed with no_key_held, which the fake spin no longer writes, and proxy.test still held key_not_enrolled to be a code the contract does not know. The refusal is key_not_enrolled now, shown with its Add Key; the unknown code is one no release writes yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24. It unblocks the Add Key action in #27.
What spin writes now. spin v20261110.01, the release
versions.yamlpins, writeskey_not_enrolled(actionadd_key, with the keys page asurl) andno_extension_release(details). It no longer writesaccess_needs_signature,keyring_needs_signatureorno_key_held(spin 22c480b66, access: a passkey's assertion buys a key). The contract still had the old three. So akey_not_enrolledfailedisErrorEnvelope, and the extension showed it as internal.What changes:
src/cli/contract.ts, the errors module and the fake spin now have spin's codes.key_not_enrolledgets whatno_key_heldhad: Add Key runsspin ssh-key add <host> <key>in a terminal, which opens the passkey page and waits. It retries once the terminal ends with exit 0.no_extension_releaseis shown with its message, asno_vscode_serveris.signKeyring,KEYRING_SIGNED, the Sign in Browser button) and thesign/sign_keyringactions are removed.hack/errcodescomparesACTION_OFwitherrorActionsin spin'scmd/cli/cmd/errcode.go, code and action, both ways.task contract:spinreads that file at the pinned release (v20261110.01) over git; at the pin it is identical to spin main's.go test ./hack/...intask testchecks the comparison logic and that this repo's contract parses.errcodes: the contract's codes are spin's;Planted bugs, each red, then reverted with Edit:
key_not_enrolledoffering Retry instead of Add Key.🤖 Generated with Claude Code