Repository navigation
test: #27's refusals in the codes #29 gave the contract - #30
Merged
Merged
Conversation
#27 and #29 merged from the same base, so main ran #27's tests against #29's contract: connect.test failed with no_key_held, which the fake spin no longer writes, and proxy.test still held key_not_enrolled to be a code the contract does not know. The refusal is key_not_enrolled now, shown with its Add Key; the unknown code is one no release writes yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24. Main is red. #27 (merged 22:06) and #29 (merged 22:10) were both branched from the same commit, so neither ran against the other. On main, #27's tests now run against #29's contract, and two of them fail:
connect.test.tsrefuses withno_key_held. The fake spin no longer writes that code, so the error came back as internal. The test now useskey_not_enrolled.proxy.test.tsexpectedkey_not_enrolledto be a code the contract does not know. It is known now. The test now checks that a refusal with it is the CLI's envelope, whichshowCliErrorshows with Add Key. The "unknown code" case uses a code no release writes yet.Only tests change. Planted bug:
proxyFailurenot treatingkey_not_enrolledas an envelope turned the new test red; reverted with Edit.🤖 Generated with Claude Code