Repository navigation
Open a workspace as spin+<workspace> when Spinbox's own resolver is active - #25
Merged
Merged
Conversation
…ctive spin-stack/open-remote-ssh resolves vscode-remote://spin+<workspace> through the spin CLI and shows in VS Code what refuses a connection. On every open Spinbox checks it is there and active: installed, a build that activates on onResolveRemoteAuthority:spin, and its activation through - which VS Code lets through only with "enable-proposed-api": ["spin-stack.open-remote-ssh"] in argv.json, since without the proposed API registerRemoteAuthorityResolver throws. Active, spin code's folder opens under spin+<workspace>; otherwise over Remote-SSH as before, and Spinbox says once per reason what is missing, with the exact argv.json line and a button to Configure Runtime Arguments. The resolver is no extensionDependencies: a dependency that fails to activate keeps its dependent from activating, so on VS Code without the argv.json line Spinbox would not activate at all, Remote-SSH fallback included. The integration suite runs VS Code stable twice with a stand-in for the resolver: without the flag the detection says disabled, with --enable-proposed-api (what argv.json gives) it says spin. Part of #24 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VS Code 1.120.0, which engines.vscode names, answers isProposedApiEnabled true for any extension that declares a proposal (`return true;// extension.enabledApiProposals.includes(proposal)`, through at least 1.128): its "CANNOT USE these API proposals" only logs, and the stand-in activated without the flag. There the resolver works without argv.json, and route() saying spin is the truth. So the disabled and spin runs use versions.yaml's vscode, 1.145.2, which enforces the gate, and the run at engines.vscode expects the resolver missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24.
Opening a workspace (the command, the tree's action, a
vscode://spin-stack.spinbox/openlink) now asks first whetherspin-stack.open-remote-ssh'sspin+<workspace>resolver is there and active:src/remote/resolver.ts): the extension is installed, the build activates ononResolveRemoteAuthority:spin, and its activation goes through. Without the proposed API, VS Code throws fromregisterRemoteAuthorityResolverand the activation rejects, so activating it is the check.spin coderuns as before (start, server prepared, progress), and its foldervscode-remote://ssh-remote+spin.<ws><path>opens asvscode-remote://spin+<ws><path>. The "VS Code downloads its own server" warning is not shown there, since the resolver refuses instead and says what to do. The status bar reads thespinremote too."enable-proposed-api": ["spin-stack.open-remote-ssh"]and a button that runs Preferences: Configure Runtime Arguments.Why no
extensionDependenciesA dependency that fails to activate keeps its dependent from activating. On VS Code stable without the argv.json line, open-remote-ssh's activation throws, so a hard dependency would leave Spinbox not activating at all, Remote-SSH fallback included. The same holds on VSCodium: its product.json allows
jeanp413.open-remote-ssh, notspin-stack.open-remote-ssh. Checked with VS Code 1.145.2:code --install-extensionof a VSIX whose dependency is in no gallery reports success and installs nothing else. So the dependency is checked at runtime, and the README says how to enable it.Tests
spin) each turned a test red, then were reverted.engines.vscode(1.120.0), alone, detection saysmissing. At versions.yaml's newvscodepin (1.145.2), with a stand-in resolver intest/integration/testdata/resolver/, it saysdisabledwithout the flag andspinwith--enable-proposed-api spin-stack.open-remote-ssh, which is what argv.json's line gives. This is the "to verify on stable" from Spinbox opens workspaces through a remote resolver of its own, so a connection's failures are ours to see and fix #24's Limit.Found on the way: 1.120 does not withhold proposed APIs
The first CI run had the disabled check on 1.120.0, and it failed. VS Code logged "CANNOT USE these API proposals 'resolvers'", yet the stand-in activated anyway. VS Code's
isProposedApiEnabledat 1.119 through at least 1.128 isreturn true;// extension.enabledApiProposals.includes(proposal);, so any extension that declares a proposal gets every proposal. 1.138 and later check it again. On those older builds the resolver works without argv.json. Detection goes by activation rather than by version or setting, so there it rightly answersspin. Only the gated build can check thedisabledpath, hence the pin.🤖 Generated with Claude Code