Repository navigation
Detect Spinbox Remote, and target VS Code 1.146 - #26
Merged
Merged
Conversation
The resolver extension is now spin-stack.spinbox-remote ("Spinbox Remote"),
installed by `spin vscode install`: the Marketplace, which VS Code reads, does
not carry an extension that uses a proposed API. Spinbox detects that id, puts
it in the argv.json line, and its message for a missing resolver says to run
`spin vscode install`.
engines.vscode is 1.146.0, the current stable, which withholds proposed APIs
from an extension argv.json does not name. So the integration runs one VS
Code, that one, and the separate vscode pin goes; so does the check for a
build of the resolver that answers no spin+, which no build of Spinbox Remote
is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24. This follows #25, which was merged before these changes reached it.
spin-stack.spinbox-remote("Spinbox Remote"). Spinbox detects that id, and the argv.json line is"enable-proposed-api": ["spin-stack.spinbox-remote"].spin vscode installin a terminal. The Visual Studio Marketplace does not carry an extension that uses a proposed API. The README has the two steps.engines.vscodeis^1.146.0, the current stable (@types/vscode1.146.0 too). That release enforces proposed APIs, so the separatevscodepin from Open a workspace as spin+<workspace> when Spinbox's own resolver is active #25 andVSCODE_GATEDare gone. The integration runs that one VS Code three times: missing, disabled without the flag, and spin with--enable-proposed-api.spin+is removed. No build of Spinbox Remote lacks it.Planted bugs, each red and then reverted with Edit: the old id in
SPIN_RESOLVER, and the missing message withoutspin vscode install.🤖 Generated with Claude Code