Repository navigation
Less code: the standard library and the helpers this repository already has - #117
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pstream and sfw Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s into the same answer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
−120 lines (+122/−242 over 31 files), no tool's behaviour changed, so no site page either. One concern per commit:
go fix ./...: the toolchain's modernizers, which spin's.golangci.ymldoes not run.slices.Sorted(maps.Keys(m))(mutate's cache and schema, gencache).refs.dedupeisslices.CompactFunc;taskgate.uniqueisslices.Sort+slices.Compact.cmp.Orfor the first value that is set (cmd/proven, ghatrace, cmd/ghatrace).exposure.Explainisallow.Split, with<kind> *in its key.fetch.FileSum, for the three identical SHA-256-of-a-file copies in toolcache, upstream and sfw.mutate.Cachetakes no lock: it is asked from main's goroutine alone.testArgsfor mutate'sRunandAsk, the targeted allowance in it.mutate-exemptinrefs.literalPrefixgoes: afterstrings.Cutthe edit it excused no longer exists.Left out on purpose:
cmd/mutate/main.go, since editing insidemain()puts the whole function under the mutate gate and its flag handling has no test; and a generic pagination helper ininternal/proven, measured at −1 line.Checked locally:
task test(84.7%),task lint(0 issues, every gate OK),task mutateagainst origin/main (159 refused, 0 survived).🤖 Generated with Claude Code