Repository navigation
mutate: a test that fails with nothing broken fails the run - #118
Merged
Merged
Conversation
…copy answers git A test that failed in mutate's copy of the module was said and left out, and the run passed: a green check over a FAIL. It now asks every edit and then exits 2 naming the test. The two that failed so here: versions/gate's TestThisRepositoryPassesTheGate asks git which files the module holds, and the copy had no repository - it now is one of its own, every file it holds staged, never the checkout's .git; and the socket test's path, under mutate's own run, was 17 bytes deeper than 108 allow - it now names the short TMPDIR it holds the tree to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On #117 the Gate job was green while its mutate step printed
--- FAILfor two tests. mutate ran each test once in its copy of the module, said the failure, asked that test about no edit, and passed. A FAIL in a green job teaches everyone to read past FAILs.The policy.
RunAllstill asks every edit, then returns an error naming each test that failed with nothing broken (Tally.Broken), andmutateexits 2.cmd/mutate/main.gois not touched: its existing error path already exits 2.The two tests that failed so:
versions/gateTestThisRepositoryPassesTheGaterunsgit ls-files, and the copy had no repository. The copy is now a git repository of its own (git init+git add -A), never the checkout's.git, and a run's reset leaves it alone. The same holds for any repository's test that asks git what the module has.internal/mutateTestARunsTemporaryDirectoryTakesASocketFromATestWithALongNamepasses undergo test, but under mutate's own run itsTMPDIRis a run's directory 17 bytes deeper, and the socket path was 110 of the 108 bytes allowed. The test now sets the shortTMPDIRit means.The site's mutate page says both: exit 2 for a test that fails with nothing broken, and the copy as a repository of its own.
For the other repositories: with this version, a test that fails only in mutate's copy turns their mutate step red instead of printing FAIL in a green job.
Checked:
task test,task lint,task site, andtask mutate(38 refused, 0 survived). A mutate run over #117's range (-base adeb9f5 -max 60) shows no test failing with nothing broken. Each new or changed test fails without its fix: the socket test with the CI run's TMPDIR, and the git test withnot a git repository.🤖 Generated with Claude Code